Support ruby 3.3.0

And also update rubocop

Author: adangel

.github/workflows/build.yml

@@ -31,16 +31,17 @@ jobs:
         key: v3-${{ runner.os }}-${{ hashFiles('pmdtester.gemspec') }}
         restore-keys: |
           v3-${{ runner.os }}-
-    - name: Set up Ruby 2.7
+    - name: Set up Ruby 3.3
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7
+        version: 3.3
     - name: Setup Environment
       shell: bash
       run: |
         echo "LANG=en_US.UTF-8" >> $GITHUB_ENV
         echo "MAVEN_OPTS=-Dmaven.wagon.httpconnectionManager.ttlSeconds=180 -Dmaven.wagon.http.retryHandler.count=3" >> $GITHUB_ENV
-        echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/pmd/build-tools/17/scripts" >> $GITHUB_ENV
+        #echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/pmd/build-tools/master/scripts" >> $GITHUB_ENV
+        echo "PMD_CI_SCRIPTS_URL=https://raw.githubusercontent.com/adangel/build-tools/ruby3/scripts" >> $GITHUB_ENV
     - name: Check Environment
       shell: bash
       run: |

.rubocop_todo.yml

@@ -1,26 +1,88 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-11-25 11:00:37 +0100 using RuboCop version 0.51.0.
+# on 2024-02-14 19:42:22 UTC using RuboCop version 1.60.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 30
-Metrics/AbcSize:
-  Max: 47
+# Offense count: 3
+# Configuration parameters: AllowedParentClasses.
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/pmdtester/cmd.rb'
+    - 'lib/pmdtester/parsers/pmd_report_document.rb'
+    - 'lib/pmdtester/parsers/projects_parser.rb'
 
-# Offense count: 6
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 135
+# Offense count: 47
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 44
 
-# Offense count: 38
-# Configuration parameters: CountComments.
+# Offense count: 93
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 22
 
 # Offense count: 3
 Naming/AccessorMethodName:
   Exclude:
     - 'lib/pmdtester/builders/pmd_report_builder.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
+# SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+Naming/VariableNumber:
+  Exclude:
+    - 'test/test_cmd.rb'
+
+# Offense count: 52
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/pmdtester/cmd.rb'
+    - 'lib/pmdtester/parsers/options.rb'
+    - 'lib/pmdtester/parsers/pmd_report_document.rb'
+    - 'lib/pmdtester/pmd_branch_detail.rb'
+    - 'lib/pmdtester/pmd_report_detail.rb'
+    - 'lib/pmdtester/project.rb'
+    - 'lib/pmdtester/report_diff.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Keywords, RequireColon.
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
+Style/CommentAnnotation:
+  Exclude:
+    - 'lib/pmdtester/builders/pmd_report_builder.rb'
+    - 'lib/pmdtester/builders/project_builder.rb'
+    - 'test/test_pmd_report_document.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/GlobalStdStream:
+  Exclude:
+    - 'lib/pmdtester.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
+# AllowedReceivers: Thread.current
+Style/HashEachMethods:
+  Exclude:
+    - 'lib/pmdtester/report_diff.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+Style/KeywordParametersOrder:
+  Exclude:
+    - 'lib/pmdtester/pmd_report_detail.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantAssignment:
+  Exclude:
+    - 'lib/pmdtester/builders/pmd_report_builder.rb'

.ruby-version

@@ -18,22 +18,23 @@ hoe = Hoe.spec 'pmdtester' do
   developer 'Binguo Bao', '[email protected]'
   developer 'Clément Fournier', '[email protected]'
 
-  self.clean_globs = %w[target/reports/**/* target/test/**/* target/dynamic-config.xml Gemfile.lock]
+  self.clean_globs = %w[target/reports/**/* target/test/**/* target/dynamic-config.xml]
   self.extra_deps += [
     ['nokogiri',        '~> 1.13'],
     ['slop',            '~> 4.9'],
     ['differ',          '~> 0.1'],
     ['rufus-scheduler', '~> 3.8'],
     ['logger-colors',   '~> 1.0'],
-    ['liquid',          '~> 5.4']
+    ['liquid',          '~> 5.4'],
+    ['base64',          '~> 0.2'],
+    ['bigdecimal',      '~> 3.1'],
   ]
   self.extra_dev_deps += [
     ['hoe-bundler',   '~> 1.5'],
     ['hoe-git',       '~> 1.6'],
     ['minitest',      '~> 5.16'],
     ['mocha',         '~> 1.16'],
-    # use the same version of rubocop as codacy
-    ['rubocop',       '~> 0.93'],
+    ['rubocop',       '~> 1.60'],
     ['test-unit',     '~> 3.5'],
     ['rdoc',          '~> 6.4']
   ]
@@ -43,7 +44,7 @@ hoe = Hoe.spec 'pmdtester' do
 end
 
 # Refers to
-# http://rubocop.readthedocs.io/en/latest/integration_with_other_tools/#rake-integration
+# https://docs.rubocop.org/rubocop/1.60/integration_with_other_tools.html#rake-integration
 RuboCop::RakeTask.new(:rubocop)
 
 # Run integration test cases

Rakefile

@@ -5,13 +5,13 @@
 
 Gem::Specification.new do |s|
   s.name = "pmdtester".freeze
-  s.version = "1.5.6.pre.SNAPSHOT"
+  s.version = "1.5.6.pre.SNAPSHOT".freeze
 
-  s.required_rubygems_version = Gem::Requirement.new("> 1.3.1".freeze) if s.respond_to? :required_rubygems_version=
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.metadata = { "bug_tracker_uri" => "https://github.com/pmd/pmd-regression-tester/issues", "homepage_uri" => "https://pmd.github.io", "source_code_uri" => "https://github.com/pmd/pmd-regression-tester" } if s.respond_to? :metadata=
   s.require_paths = ["lib".freeze]
   s.authors = ["Andreas Dangel".freeze, "Binguo Bao".freeze, "Cl\u00E9ment Fournier".freeze]
-  s.date = "2023-11-16"
+  s.date = "2024-02-14"
   s.description = "A regression testing tool ensure that new problems and unexpected behaviors will not be introduced to PMD project after fixing an issue , and new rules can work as expected.".freeze
   s.email = ["[email protected]".freeze, "[email protected]".freeze, "[email protected]".freeze]
   s.executables = ["pmdtester".freeze]
@@ -21,44 +21,27 @@ Gem::Specification.new do |s|
   s.licenses = ["BSD-2-Clause".freeze]
   s.rdoc_options = ["--main".freeze, "README.rdoc".freeze]
   s.required_ruby_version = Gem::Requirement.new(">= 2.7".freeze)
-  s.rubygems_version = "3.1.6".freeze
+  s.rubygems_version = "3.5.3".freeze
   s.summary = "A regression testing tool ensure that new problems and unexpected behaviors will not be introduced to PMD project after fixing an issue , and new rules can work as expected.".freeze
 
-  if s.respond_to? :specification_version then
-    s.specification_version = 4
-  end
+  s.specification_version = 4
 
-  if s.respond_to? :add_runtime_dependency then
-    s.add_runtime_dependency(%q<nokogiri>.freeze, ["~> 1.13"])
-    s.add_runtime_dependency(%q<slop>.freeze, ["~> 4.9"])
-    s.add_runtime_dependency(%q<differ>.freeze, ["~> 0.1"])
-    s.add_runtime_dependency(%q<rufus-scheduler>.freeze, ["~> 3.8"])
-    s.add_runtime_dependency(%q<logger-colors>.freeze, ["~> 1.0"])
-    s.add_runtime_dependency(%q<liquid>.freeze, ["~> 5.4"])
-    s.add_development_dependency(%q<hoe-bundler>.freeze, ["~> 1.5"])
-    s.add_development_dependency(%q<hoe-git>.freeze, ["~> 1.6"])
-    s.add_development_dependency(%q<minitest>.freeze, ["~> 5.16"])
-    s.add_development_dependency(%q<mocha>.freeze, ["~> 1.16"])
-    s.add_development_dependency(%q<rubocop>.freeze, ["~> 0.93"])
-    s.add_development_dependency(%q<test-unit>.freeze, ["~> 3.5"])
-    s.add_development_dependency(%q<rdoc>.freeze, ["~> 6.4"])
-    s.add_development_dependency(%q<hoe>.freeze, ["~> 3.26"])
-  else
-    s.add_dependency(%q<nokogiri>.freeze, ["~> 1.13"])
-    s.add_dependency(%q<slop>.freeze, ["~> 4.9"])
-    s.add_dependency(%q<differ>.freeze, ["~> 0.1"])
-    s.add_dependency(%q<rufus-scheduler>.freeze, ["~> 3.8"])
-    s.add_dependency(%q<logger-colors>.freeze, ["~> 1.0"])
-    s.add_dependency(%q<liquid>.freeze, ["~> 5.4"])
-    s.add_dependency(%q<hoe-bundler>.freeze, ["~> 1.5"])
-    s.add_dependency(%q<hoe-git>.freeze, ["~> 1.6"])
-    s.add_dependency(%q<minitest>.freeze, ["~> 5.16"])
-    s.add_dependency(%q<mocha>.freeze, ["~> 1.16"])
-    s.add_dependency(%q<rubocop>.freeze, ["~> 0.93"])
-    s.add_dependency(%q<test-unit>.freeze, ["~> 3.5"])
-    s.add_dependency(%q<rdoc>.freeze, ["~> 6.4"])
-    s.add_dependency(%q<hoe>.freeze, ["~> 3.26"])
-  end
+  s.add_runtime_dependency(%q<nokogiri>.freeze, ["~> 1.13".freeze])
+  s.add_runtime_dependency(%q<slop>.freeze, ["~> 4.9".freeze])
+  s.add_runtime_dependency(%q<differ>.freeze, ["~> 0.1".freeze])
+  s.add_runtime_dependency(%q<rufus-scheduler>.freeze, ["~> 3.8".freeze])
+  s.add_runtime_dependency(%q<logger-colors>.freeze, ["~> 1.0".freeze])
+  s.add_runtime_dependency(%q<liquid>.freeze, ["~> 5.4".freeze])
+  s.add_runtime_dependency(%q<base64>.freeze, ["~> 0.2".freeze])
+  s.add_runtime_dependency(%q<bigdecimal>.freeze, ["~> 3.1".freeze])
+  s.add_development_dependency(%q<hoe-bundler>.freeze, ["~> 1.5".freeze])
+  s.add_development_dependency(%q<hoe-git>.freeze, ["~> 1.6".freeze])
+  s.add_development_dependency(%q<minitest>.freeze, ["~> 5.16".freeze])
+  s.add_development_dependency(%q<mocha>.freeze, ["~> 1.16".freeze])
+  s.add_development_dependency(%q<rubocop>.freeze, ["~> 1.60".freeze])
+  s.add_development_dependency(%q<test-unit>.freeze, ["~> 3.5".freeze])
+  s.add_development_dependency(%q<rdoc>.freeze, ["~> 6.4".freeze])
+  s.add_development_dependency(%q<hoe>.freeze, ["~> 3.26".freeze])
 end
 
 # DO NOT EDIT THIS FILE. Instead, edit Rakefile, and run `rake hoe:spec`.