Fix rubocop

Author: oowekyala

.rubocop.yml

@@ -20,6 +20,10 @@ Metrics/MethodLength:
   Exclude:
     - 'lib/pmdtester/parsers/options.rb'
 
+Metrics/ClassLength:
+  Exclude:
+    - '**/*'
+
 Metrics/BlockLength:
   Exclude:
     - 'lib/pmdtester/parsers/options.rb'

lib/pmdtester/builders/diff_report/violations.rb

@@ -39,15 +39,7 @@ def build_violation_table_body(doc, key, value)
   end
 
   def build_violation_table_row(doc, key, pmd_violation)
-    klass = if pmd_violation.changed
-              'd'
-            elsif pmd_violation.branch == PmdTester::BASE
-              'b'
-            else
-              'a'
-            end
-
-    doc.tr(class: klass) do
+    doc.tr(class: get_css_class(pmd_violation)) do
       build_table_anchor_column(doc, 'A', increment_violation_index)
 
       violation = pmd_violation.attrs
@@ -92,4 +84,16 @@ def increment_violation_index
     @violation_index ||= 0 # init with 0
     @violation_index += 1
   end
+
+  private
+
+  def get_css_class(pmd_violation)
+    if pmd_violation.changed
+      'd'
+    elsif pmd_violation.branch == PmdTester::BASE
+      'b'
+    else
+      'a'
+    end
+  end
 end

lib/pmdtester/builders/summary_report_builder.rb

@@ -142,8 +142,7 @@ def build_projects_table_body(doc)
             end
             doc.td project.tag
             doc.td do
-              build_table_content_for(doc, project.removed_errors_size,
-                                      project.new_errors_size)
+              build_table_content_for(doc, project.removed_errors_size, project.new_errors_size)
             end
             doc.td do
               build_table_content_for(doc, project.removed_violations_size,

lib/pmdtester/report_diff.rb

@@ -94,8 +94,12 @@ def calculate_violations(base_violations, patch_violations)
       @violation_diffs = build_diffs(base_violations.violations, patch_violations.violations)
       @violation_diffs = merge_changed_violations(@violation_diffs)
 
-      @new_violations_size, @changed_violations_size, @removed_violations_size = get_diffs_size(@violation_diffs)
-      @violation_diffs_size = @new_violations_size + @changed_violations_size + @removed_violations_size
+      @new_violations_size,
+          @changed_violations_size,
+          @removed_violations_size = get_diffs_size(@violation_diffs)
+      @violation_diffs_size = @new_violations_size +
+                              @changed_violations_size +
+                              @removed_violations_size
     end
 
     def calculate_errors(base_errors, patch_errors)

test/test_diff_builder.rb

@@ -27,9 +27,7 @@ def test_violation_diffs
     assert_equal(8, diffs_report.patch_violations_size)
     assert_equal(6, diffs_report.violation_diffs_size)
 
-    assert_equal(1, diffs_report.removed_violations_size)
-    assert_equal(4, diffs_report.new_violations_size)
-    assert_equal(1, diffs_report.changed_violations_size)
+    assert_violations_equal(diffs_report, 1, 4, 1)
 
     assert_equal('Base1.java', keys[0])
     assert_equal('SameFileNameWithDiffViolations.java', keys[1])
@@ -102,4 +100,12 @@ def test_diff_exist
     report_diffs.violation_diffs_size = 0
     assert_equal(true, report_diffs.diffs_exist?)
   end
+
+  private
+
+  def assert_violations_equal(diffs_report, removed, added, changed)
+    assert_equal(removed, diffs_report.removed_violations_size)
+    assert_equal(added, diffs_report.new_violations_size)
+    assert_equal(changed, diffs_report.changed_violations_size)
+  end
 end