Fix XML parser to deal with entities

Author: adangel

lib/pmdtester/parsers/pmd_report_document.rb

@@ -47,7 +47,7 @@ def remove_work_dir!(str)
     end
 
     def characters(string)
-      @current_violation&.text = string
+      @current_violation&.text += string
     end
 
     def end_element(name)
@@ -56,6 +56,7 @@ def end_element(name)
         @violations.add_violations_by_filename(@current_filename, @current_violations)
         @current_filename = nil
       when 'violation'
+        @current_violation&.text.strip!
         @current_violations.push(@current_violation) if match_filter_set?(@current_violation)
         @current_violation = nil
       when 'error'

test/resources/pmd_report_document/test_document.xml

@@ -5,7 +5,7 @@
     version="6.3.0-SNAPSHOT" timestamp="2018-04-16T22:41:45.065">
 <file name="SHOULD_BE_REPLACED/target/repositories/spring-framework/gradle/jdiff/Null.java">
 <violation beginline="7" endline="8" begincolumn="12" endcolumn="5" rule="UncommentedEmptyConstructor" ruleset="Documentation" class="Null" method="Null" externalInfoUrl="http://pmd.sourceforge.net/snapshot/pmd_rules_java_documentation.html#uncommentedemptyconstructor" priority="3">
-Document empty constructor
+Document &apos;empty&apos; constructor
 </violation>
 </file>
 <file name="SHOULD_BE_REPLACED/target/repositories/spring-framework/spring-aop/src/main/java/org/springframework/aop/ClassFilter.java">

test/test_pmd_report_document.rb

@@ -9,6 +9,7 @@ def test_document
     parser = Nokogiri::XML::SAX::Parser.new(doc)
     parser.parse(File.open('test/resources/pmd_report_document/test_document.xml'))
     assert_equal(8, doc.violations.violations_size)
+    assert_equal('Document \'empty\' constructor', doc.violations.violations['/target/repositories/spring-framework/gradle/jdiff/Null.java'][0].text)
     assert_equal(2, doc.errors.errors_size)
     pmd_errors = doc.errors.errors.values
     assert_not_nil(pmd_errors[0])