Skip to content

Commit 6d2b767

Browse files
committed
Update integration tests for pmd 7
1 parent a21e941 commit 6d2b767

File tree

4 files changed

+16
-13
lines changed

4 files changed

+16
-13
lines changed

README.rdoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,10 @@ The tool creates the following folders:
136136
bundle exec pmdtester ... # run this to directly execute pmdtester from source
137137

138138
Run a single test class, e.g.:
139-
bundle exec ruby -I test test/test_diff_report_builder.rb
139+
bundle exec ruby -I test test/test_project_diff_report.rb
140140

141141
Run a single test, e.g.:
142-
bundle exec ruby -I test test/test_diff_report_builder.rb -n test_diff_report_builder
142+
bundle exec ruby -I test test/test_project_diff_report.rb -n test_diff_report_builder
143143

144144
=== Releasing
145145

lib/pmdtester/builders/pmd_report_builder.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ def build_pmd(into_dir:)
7070
' -Dcheckstyle.skip=true' \
7171
' -Dpmd.skip=true' \
7272
' -T1C -B'
73+
logger.debug "#{@pmd_branch_name}: maven command: #{package_cmd}"
7374
Cmd.execute_successfully(package_cmd)
7475
end
7576

lib/pmdtester/cmd.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def self.execute_successfully(cmd)
3030
stdout, stderr, status = internal_execute(cmd)
3131

3232
unless status.success?
33+
logger.error "Command failed: #{cmd}"
3334
logger.error stdout
3435
logger.error stderr
3536
raise CmdException.new(cmd, stdout, stderr, status)

test/integration_test_runner.rb

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -69,22 +69,23 @@ def test_single_mode_with_html_flag_option
6969
end
7070

7171
def test_online_mode
72-
# This test depends on the file test_branch_2-baseline.zip being available at:
73-
# https://pmd-code.org/pmd-regression-tester/test_branch_2-baseline.zip
74-
base_branch = 'test_branch_2'
75-
argv = "-r target/repositories/pmd -m online -b #{base_branch} -p pmd_releases/6.41.0 " \
72+
# This test depends on the file pmd_releases_7.0.0-rc1-baseline.zip being available at:
73+
# https://pmd-code.org/pmd-regression-tester/pmd_releases_7.0.0-rc1-baseline.zip
74+
base_branch = 'pmd_releases/7.0.0-rc1'
75+
patch_branch = 'pmd_releases/7.0.0-rc2'
76+
argv = "-r target/repositories/pmd -m online -b #{base_branch} -p #{patch_branch} " \
7677
'--baseline-download-url https://pmd-code.org/pmd-regression-tester/' \
7778
' --threads ' + Etc.nprocessors.to_s
7879

7980
system("bundle exec bin/pmdtester #{argv}")
8081

81-
assert_path_exist("target/reports/#{base_branch}-baseline.zip")
82-
assert_path_exist("target/reports/#{base_branch}/checkstyle/pmd_report.xml")
83-
assert_path_exist("target/reports/#{base_branch}/spring-framework/pmd_report.xml")
84-
assert_path_exist('target/reports/pmd_releases_6.41.0/checkstyle/pmd_report.xml')
85-
assert_path_exist('target/reports/pmd_releases_6.41.0/checkstyle/config.xml')
86-
assert_path_exist('target/reports/pmd_releases_6.41.0/spring-framework/pmd_report.xml')
87-
assert_path_exist('target/reports/pmd_releases_6.41.0/spring-framework/config.xml')
82+
assert_path_exist("target/reports/#{base_branch.tr('/', '_')}-baseline.zip")
83+
assert_path_exist("target/reports/#{base_branch.tr('/', '_')}/checkstyle/pmd_report.xml")
84+
assert_path_exist("target/reports/#{base_branch.tr('/', '_')}/spring-framework/pmd_report.xml")
85+
assert_path_exist("target/reports/#{patch_branch.tr('/', '_')}/checkstyle/pmd_report.xml")
86+
assert_path_exist("target/reports/#{patch_branch.tr('/', '_')}/checkstyle/config.xml")
87+
assert_path_exist("target/reports/#{patch_branch.tr('/', '_')}/spring-framework/pmd_report.xml")
88+
assert_path_exist("target/reports/#{patch_branch.tr('/', '_')}/spring-framework/config.xml")
8889
assert_path_exist('target/reports/diff/checkstyle/index.html')
8990
assert_path_exist('target/reports/diff/spring-framework/index.html')
9091
assert_path_exist('target/reports/diff/index.html')

0 commit comments

Comments
 (0)