Fix nesting problem

Author: oowekyala

lib/pmdtester/builders/project_hasher.rb

@@ -2,7 +2,6 @@
 
 require 'differ'
 
-# the same module as all the others? come on rubocop
 module PmdTester
   # Turn a project report into a hash that can be rendered somewhere else
   module ProjectHasher
@@ -46,68 +45,68 @@ def violations_to_hash(project)
         'violations' => all_vs
       }
     end
-  end
 
-  def link_template(project)
-    l_str = project.type == 'git' ? 'L' : 'l'
-    "#{project.webview_url}/{file}##{l_str}{line}"
-  end
+    def link_template(project)
+      l_str = project.type == 'git' ? 'L' : 'l'
+      "#{project.webview_url}/{file}##{l_str}{line}"
+    end
 
-  def violation_type(violation)
-    if violation.changed?
-      '~'
-    elsif violation.branch == 'patch'
-      '+'
-    else
-      '-'
+    def violation_type(violation)
+      if violation.changed?
+        '~'
+      elsif violation.branch == 'patch'
+        '+'
+      else
+        '-'
+      end
     end
-  end
 
-  def make_violation_hash(file_ref, violation)
-    h = {
-      't' => violation_type(violation),
-      'l' => violation.line,
-      'f' => file_ref,
-      'r' => violation.rule_name,
-      'm' => violation.changed? ? diff_fragments(violation) : violation.message
-    }
-    h['ol'] = violation.old_line if violation.changed? && violation.line != violation.old_line
-    h
-  end
+    def make_violation_hash(file_ref, violation)
+      h = {
+        't' => violation_type(violation),
+        'l' => violation.line,
+        'f' => file_ref,
+        'r' => violation.rule_name,
+        'm' => violation.changed? ? diff_fragments(violation) : violation.message
+      }
+      h['ol'] = violation.old_line if violation.changed? && violation.line != violation.old_line
+      h
+    end
 
-  def diff_fragments(violation)
-    diff = Differ.diff_by_word(violation.message, violation.old_message)
-    diff.format_as(:html)
-  end
+    def diff_fragments(violation)
+      diff = Differ.diff_by_word(violation.message, violation.old_message)
+      diff.format_as(:html)
+    end
 
-  def error_to_hash(error, project)
-    escaped_stacktrace = sanitize_stacktrace(error)
-    old_stacktrace = error.old_error.nil? ? nil : sanitize_stacktrace(error.old_error)
-
-    {
-      'file_url' => project.get_webview_url(error.filename),
-      'stack_trace_html' => escaped_stacktrace,
-      'old_stack_trace_html' => old_stacktrace,
-      'short_message' => error.short_message,
-      'short_filename' => error.short_filename,
-      'filename' => error.filename,
-      'change_type' => change_type(error)
-    }
-  end
+    def error_to_hash(error, project)
+      escaped_stacktrace = sanitize_stacktrace(error)
+      old_stacktrace = error.old_error.nil? ? nil : sanitize_stacktrace(error.old_error)
 
-  def sanitize_stacktrace(error)
-    CGI.escapeHTML(error.stack_trace)
-       .gsub(error.filename, '<span class="meta-var">$FILE</span>')
-       .gsub(/\w++(?=\(\w++\.java:\d++\))/, '<span class="stack-trace-method">\\0</span>')
-  end
+      {
+        'file_url' => project.get_webview_url(error.filename),
+        'stack_trace_html' => escaped_stacktrace,
+        'old_stack_trace_html' => old_stacktrace,
+        'short_message' => error.short_message,
+        'short_filename' => error.short_filename,
+        'filename' => error.filename,
+        'change_type' => change_type(error)
+      }
+    end
+
+    def sanitize_stacktrace(error)
+      CGI.escapeHTML(error.stack_trace)
+         .gsub(error.filename, '<span class="meta-var">$FILE</span>')
+         .gsub(/\w++(?=\(\w++\.java:\d++\))/, '<span class="stack-trace-method">\\0</span>')
+    end
 
-  def change_type(item)
-    if item.branch == BASE
-      'removed'
-    elsif item.changed?
-      'changed'
-    else
-      'added'
+    def change_type(item)
+      if item.branch == BASE
+        'removed'
+      elsif item.changed?
+        'changed'
+      else
+        'added'
+      end
     end
   end
 end

pmdtester.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.metadata = { "bug_tracker_uri" => "https://github.com/pmd/pmd-regression-tester/issues", "homepage_uri" => "https://pmd.github.io", "source_code_uri" => "https://github.com/pmd/pmd-regression-tester" } if s.respond_to? :metadata=
   s.require_paths = ["lib".freeze]
   s.authors = ["Andreas Dangel".freeze, "Binguo Bao".freeze]
-  s.date = "2020-11-23"
+  s.date = "2020-11-25"
   s.description = "A regression testing tool ensure that new problems and unexpected behaviors will not be introduced to PMD project after fixing an issue , and new rules can work as expected.".freeze
   s.email = ["[email protected]".freeze, "[email protected]".freeze]
   s.executables = ["pmdtester".freeze]