Fix #124: If an abstract rule is changed, run all rules (#141)

Author: adangel

History.md

@@ -5,11 +5,13 @@
 ## Enhancements
 
 ## Fixed Issues
+* [#124](https://github.com/pmd/pmd-regression-tester/issues/124): With `--auto-gen-config` invalid rule references might be generated
 * [#139](https://github.com/pmd/pmd-regression-tester/pull/139): chore: CI Improvements
 
-## Dependency Updates
+## Merge pull requests
+* [#141](https://github.com/pmd/pmd-regression-tester/pull/141): Fix #124: If an abstract rule is changed, run all rules - [UncleOwen](https://github.com/UncleOwen) (@UncleOwen)
 
-## External Contributions
+## Dependency Updates
 
 # 1.6.0 / 2025-07-25
 

lib/pmdtester/builders/rule_set_builder.rb

@@ -146,7 +146,7 @@ def check_single_filename?(filename, categories, rules)
 
       # matches Java-based rule implementations
       match_data = %r{.+/src/main/java/.+/lang/([^/]+)/rule/([^/]+)/([^/]+)Rule.java}.match(filename)
-      unless match_data.nil?
+      unless match_data.nil? || match_data[3].start_with?('Abstract')
         logger.debug "Matches: #{match_data.inspect}"
         rules.add("#{match_data[1]}/#{match_data[2]}.xml/#{match_data[3]}")
         return true

test/test_rule_set_builder.rb

@@ -46,6 +46,16 @@ def test_build_design_codestyle_config
     assert_equal(expected, actual)
   end
 
+  def test_build_all_rulesets_config_abstract_rule_changed
+    diff_filenames = <<~DOC
+      pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/internal/AbstractJavaRulechainRule.java
+    DOC
+    mock_build?(diff_filenames, nil, "#{PATH_TO_TEST_RESOURCES}/patch-ruleset.xml")
+
+    assert(!File.exist?(RuleSetBuilder::PATH_TO_DYNAMIC_CONFIG),
+           "File #{RuleSetBuilder::PATH_TO_DYNAMIC_CONFIG} must not exist")
+  end
+
   def test_build_all_rulesets_config
     diff_filenames = <<~DOC
       pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/AvoidGlobalModifierRule.java