Skip to content

Commit bfe46f7

Browse files
committed
Merge branch 'pr-30'
2 parents caf7016 + db1ab42 commit bfe46f7

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

History.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## External Contributions
44

55
* [#28](https://github.com/pmd/pmd-regression-tester/pull/28): Refactor require statements - [BBG](https://github.com/djydewang)
6+
* [#30](https://github.com/pmd/pmd-regression-tester/pull/30): Fix diff_cmd in RuleSetBuilder - [BBG](https://github.com/djydewang)
67

78
# 1.0.0.beta2 / 2018-07-17
89

lib/pmdtester/builders/rule_set_builder.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def diff_filenames
4646
base = @options.base_branch
4747
patch = @options.patch_branch
4848
# We only need to support git here, since PMD's repo is using git.
49-
diff_cmd = "git diff --name-only #{base}..#{patch} -- pmd/core pmd/java"
49+
diff_cmd = "git diff --name-only #{base}..#{patch} -- pmd-core pmd-java"
5050
filenames = Cmd.execute(diff_cmd)
5151
end
5252
filenames.split("\n")
@@ -78,7 +78,7 @@ def get_rule_sets(filenames)
7878

7979
def build_config_file(rule_sets)
8080
if rule_sets.empty?
81-
puts NO_JAVA_RULES_CHANGED_MESSAGE
81+
logger.info NO_JAVA_RULES_CHANGED_MESSAGE
8282
exit 0
8383
end
8484

0 commit comments

Comments
 (0)