Fix more rubocop offenses

Author: adangel

lib/pmdtester/builders/pmd_report_builder.rb

@@ -251,24 +251,24 @@ def find_pmd_dist_target
     def build_pmd_with_maven
       logger.info "#{@pmd_branch_name}: Building PMD #{@pmd_version}..."
 
-      if Semver.compare(@pmd_version, '7.14.0') >= 0
-        # build command since PMD migrated to central portal
-        package_cmd = './mvnw clean package ' \
-                      '-PfastSkip ' \
-                      '-DskipTests ' \
-                      '-T1C -B'
-      else
-        # build command for older PMD versions
-        package_cmd = './mvnw clean package ' \
-                      "-s #{ResourceLocator.resource('maven-settings.xml')} " \
-                      '-Pfor-dokka-maven-plugin ' \
-                      '-Dmaven.test.skip=true ' \
-                      '-Dmaven.javadoc.skip=true ' \
-                      '-Dmaven.source.skip=true ' \
-                      '-Dcheckstyle.skip=true ' \
-                      '-Dpmd.skip=true ' \
-                      '-T1C -B'
-      end
+      package_cmd = if Semver.compare(@pmd_version, '7.14.0') >= 0
+                      # build command since PMD migrated to central portal
+                      './mvnw clean package ' \
+                        '-PfastSkip ' \
+                        '-DskipTests ' \
+                        '-T1C -B'
+                    else
+                      # build command for older PMD versions
+                      './mvnw clean package ' \
+                        "-s #{ResourceLocator.resource('maven-settings.xml')} " \
+                        '-Pfor-dokka-maven-plugin ' \
+                        '-Dmaven.test.skip=true ' \
+                        '-Dmaven.javadoc.skip=true ' \
+                        '-Dmaven.source.skip=true ' \
+                        '-Dcheckstyle.skip=true ' \
+                        '-Dpmd.skip=true ' \
+                        '-T1C -B'
+                    end
 
       logger.debug "#{@pmd_branch_name}: maven command: #{package_cmd}"
       Cmd.execute_successfully(package_cmd)

test/test_pmd_report_builder.rb

@@ -154,7 +154,7 @@ def test_build_normal_pmd7_new_build
 
     # PMD binary does not exist yet this time...
     record_expectations(sha1_head: 'sha1abc', sha1_base: 'sha1abc', zip_file_exists: false)
-    stub_pmd_build_maven_new_pmd7_build()
+    stub_pmd_build_maven_new_pmd7_build
     PmdTester::Cmd.stubs(:execute_successfully).with(
       "unzip -qo pmd-dist/target/pmd-dist-#{@pmd_version}-bin.zip " \
       '-d pmd-dist/target/exploded'
@@ -383,7 +383,7 @@ def stub_pmd_build_maven(binary_name:)
     end.once
   end
 
-  def stub_pmd_build_maven_new_pmd7_build()
+  def stub_pmd_build_maven_new_pmd7_build
     PmdTester::Cmd.stubs(:execute_successfully).with do |cmd|
       if cmd == './mvnw clean package ' \
                 '-PfastSkip ' \