Skip to content

Commit e442ef9

Browse files
committed
Improve logging
1 parent 2045f80 commit e442ef9

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ hoe = Hoe.spec 'pmdtester' do
1919

2020
self.clean_globs = %w[target/reports/**/* target/test/**/* target/dynamic-config.xml Gemfile.lock]
2121
self.extra_deps += [['nokogiri', '~> 1.8'], ['slop', '~> 4.6'], ['differ', '~> 0.1'],
22-
['rufus-scheduler', '~> 3.5']]
22+
['rufus-scheduler', '~> 3.5'], ['logger-colors', '~> 1.0']]
2323
self.extra_dev_deps += [
2424
['hoe-bundler', '~> 1.5'],
2525
['hoe-git', '~> 1.6'],

lib/pmdtester.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# frozen_string_literal: true
22

33
require 'logger'
4+
require 'logger/colors'
45

56
require_relative 'pmdtester/cmd'
67
require_relative 'pmdtester/pmd_branch_detail'

lib/pmdtester/builders/pmd_report_builder.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,8 @@ def checkout_build_branch
170170

171171
# working dir is dirty....
172172
# we don't allow this because we need the SHA to address the zip file
173-
logger.error 'Won\'t build without a clean working tree, commit your changes'
173+
logger.error "#{@pmd_branch_name}: Won\'t build without a clean working tree, " \
174+
'commit your changes'
174175
end
175176

176177
def work_dir

pmdtester.gemspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
1111
s.metadata = { "bug_tracker_uri" => "https://github.com/pmd/pmd-regression-tester/issues", "homepage_uri" => "https://pmd.github.io", "source_code_uri" => "https://github.com/pmd/pmd-regression-tester" } if s.respond_to? :metadata=
1212
s.require_paths = ["lib".freeze]
1313
s.authors = ["Andreas Dangel".freeze, "Binguo Bao".freeze]
14-
s.date = "2020-11-25"
14+
s.date = "2020-11-28"
1515
s.description = "A regression testing tool ensure that new problems and unexpected behaviors will not be introduced to PMD project after fixing an issue , and new rules can work as expected.".freeze
1616
s.email = ["[email protected]".freeze, "[email protected]".freeze]
1717
s.executables = ["pmdtester".freeze]
@@ -33,6 +33,7 @@ Gem::Specification.new do |s|
3333
s.add_runtime_dependency(%q<slop>.freeze, ["~> 4.6"])
3434
s.add_runtime_dependency(%q<differ>.freeze, ["~> 0.1"])
3535
s.add_runtime_dependency(%q<rufus-scheduler>.freeze, ["~> 3.5"])
36+
s.add_runtime_dependency(%q<logger-colors>.freeze, ["~> 1.0"])
3637
s.add_development_dependency(%q<hoe-bundler>.freeze, ["~> 1.5"])
3738
s.add_development_dependency(%q<hoe-git>.freeze, ["~> 1.6"])
3839
s.add_development_dependency(%q<minitest>.freeze, ["~> 5.10"])
@@ -46,6 +47,7 @@ Gem::Specification.new do |s|
4647
s.add_dependency(%q<slop>.freeze, ["~> 4.6"])
4748
s.add_dependency(%q<differ>.freeze, ["~> 0.1"])
4849
s.add_dependency(%q<rufus-scheduler>.freeze, ["~> 3.5"])
50+
s.add_dependency(%q<logger-colors>.freeze, ["~> 1.0"])
4951
s.add_dependency(%q<hoe-bundler>.freeze, ["~> 1.5"])
5052
s.add_dependency(%q<hoe-git>.freeze, ["~> 1.6"])
5153
s.add_dependency(%q<minitest>.freeze, ["~> 5.10"])

0 commit comments

Comments
 (0)