Skip to content

Commit f5797c3

Browse files
committed
Fix numbers for test-case-1
Note: the changed errors are due to different thread settings
1 parent 891fad8 commit f5797c3

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

test/manual_integration_tests.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,29 +46,29 @@ def test_case_1_single_java_rule_changed
4646
assert_equal(0, @summary[:violations][:changed], 'found changed violations')
4747
assert_equal(0, @summary[:violations][:new], 'found new violations')
4848
# These are the artificially created false-negatives for AbstractClassWithoutAbstractMethod rule
49-
# checkstyle: 204 violations
49+
# checkstyle: 195 violations
5050
# spring-framework: 280 violations
5151
# openjdk11: 29 violations
52-
# -> total = 513
53-
assert_equal(204 + 280 + 29, @summary[:violations][:removed], 'found removed violations')
52+
# -> total = 504
53+
assert_equal(195 + 280 + 29, @summary[:violations][:removed], 'found removed violations')
5454

5555
# errors might have been caused in the baseline for other rules (only visible in the stacktrace)
5656
# hence they might appear as removed
5757

5858
# project "apex-link" has 2 errors, since we only executed java rules, 2 errors are removed
59-
assert_equal(2, @summary[:errors][:removed], 'found removed errors')
60-
assert_equal(0, @summary[:errors][:changed], 'found changed errors')
59+
# project "checkstyle" has 10 errors removed and 11 changed
60+
# project "openjdk-11" has 1 error changed
61+
# project "spring-framework" has 1 error removed
62+
assert_equal(13, @summary[:errors][:removed], 'found removed errors')
63+
assert_equal(12, @summary[:errors][:changed], 'found changed errors')
6164
assert_equal(0, @summary[:errors][:new], 'found new errors')
6265
assert_equal(0, @summary[:configerrors][:changed], 'found changed configerrors')
6366
assert_equal(0, @summary[:configerrors][:new], 'found new configerrors')
64-
# Only the rule AbstractClassWithoutAbtractMethod has been executed, so the
65-
# configerrors about LoosePackageCoupling are gone, one for each project
66-
# we now have 7 projects in total (4 java, 3 apex)
67-
assert_equal(7, @summary[:configerrors][:removed], 'found removed configerrors')
67+
assert_equal(0, @summary[:configerrors][:removed], 'found removed configerrors')
6868

6969
assert_equal("This changeset changes 0 violations,\n" \
7070
"introduces 0 new violations, 0 new errors and 0 new configuration errors,\n" \
71-
'removes 513 violations, 2 errors and 7 configuration errors.',
71+
'removes 504 violations, 13 errors and 0 configuration errors.',
7272
create_summary_message)
7373

7474
assert_file_equals("#{PATCHES_PATH}/expected_patch_config_1.xml", 'target/reports/diff/patch_config.xml')

0 commit comments

Comments
 (0)