Refactor progress logging, refs #60

Author: adangel

lib/pmdtester.rb

@@ -13,6 +13,7 @@
 require_relative 'pmdtester/resource_locator'
 require_relative 'pmdtester/runner'
 
+require_relative 'pmdtester/builders/simple_progress_logger'
 require_relative 'pmdtester/builders/html_report_builder'
 require_relative 'pmdtester/builders/diff_builder'
 require_relative 'pmdtester/builders/diff_report/violations'

lib/pmdtester/builders/pmd_report_builder.rb

@@ -141,16 +141,11 @@ def generate_pmd_reports
 
       sum_time = 0
       @projects.each do |project|
-        logger.info "Starting to generate #{project.name}'s PMD report"
-        message_counter = 1
-        scheduler = Rufus::Scheduler.new
-        scheduler.every '2m' do
-          logger.info "Still generating #{project.name}'s PMD report (#{message_counter})..."
-          message_counter += 1
-        end
+        progress_logger = SimpleProgressLogger.new(project.name)
+        progress_logger.start
         generate_config_for(project)
         execution_time, end_time = generate_pmd_report(project)
-        scheduler.shutdown
+        progress_logger.stop
         sum_time += execution_time
 
         report_details = PmdReportDetail.new

lib/pmdtester/builders/simple_progress_logger.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'rufus-scheduler'
+
+module PmdTester
+  # Helper class that provides a simple progress logging
+  class SimpleProgressLogger
+    include PmdTester
+    def initialize(project_name)
+      @project_name = project_name
+    end
+
+    def start
+      logger.info "Starting to generate #{@project_name}'s PMD report"
+      message_counter = 1
+      @scheduler = Rufus::Scheduler.new
+      @scheduler.every '2m' do
+        logger.info "Still generating #{@project_name}'s PMD report (#{message_counter})..."
+        message_counter += 1
+      end
+    end
+
+    def stop
+      @scheduler.shutdown
+    end
+  end
+end