Merge pull request #76 from oowekyala/pmd-regression-tester:speed

Speedup XML parsing #76

Author: adangel

History.md

@@ -16,6 +16,7 @@ Typeresolution is now supported by two new tags in the project-list.xml file:
 *   [#70](https://github.com/pmd/pmd-regression-tester/pull/70): Add link to PR on github in HTML report
 *   [#74](https://github.com/pmd/pmd-regression-tester/pull/74): Merge violations that have just changed messages
 *   [#75](https://github.com/pmd/pmd-regression-tester/pull/75): Add new option "--error-recovery"
+*   [#76](https://github.com/pmd/pmd-regression-tester/pull/76): Speedup XML parsing
 
 ## External Contributions
 

lib/pmdtester/parsers/pmd_report_document.rb

@@ -58,8 +58,10 @@ def end_element(name)
         @violations.add_violations_by_filename(@current_filename, @current_violations)
         @current_filename = nil
       when 'violation'
-        @current_violation.text.strip!
-        @current_violations.push(@current_violation) if match_filter_set?(@current_violation)
+        if match_filter_set?(@current_violation)
+          @current_violation.text.strip!
+          @current_violations.push(@current_violation)
+        end
         @current_violation = nil
       when 'error'
         @errors.add_error_by_filename(@current_filename, @current_error)
@@ -79,15 +81,12 @@ def cdata_block(string)
     def match_filter_set?(violation)
       return true if @filter_set.nil?
 
-      @filter_set.each do |filter_rule_ref|
-        ruleset_attr = violation.attrs['ruleset'].delete(' ').downcase + '.xml'
-        rule = violation.rule_name
-        rule_ref = "#{ruleset_attr}/#{rule}"
-        return true if filter_rule_ref.eql?(ruleset_attr)
-        return true if filter_rule_ref.eql?(rule_ref)
-      end
+      ruleset_attr = violation.attrs['ruleset'].delete(' ').downcase + '.xml'
+      return true if @filter_set.include?(ruleset_attr)
+
+      rule_ref = "#{ruleset_attr}/#{violation.rule_name}"
 
-      false
+      @filter_set.include?(rule_ref)
     end
   end
 end