resolve feedback

Addresses phpstan#3613 (comment) and phpstan#3613 (comment)

The relevate lowercase-string tests do not seem to be affected ... ?

Author: pmjones

src/Type/Accessory/AccessoryLowercaseStringType.php

@@ -311,7 +311,7 @@ public function isLowercaseString(): TrinaryLogic
 
 	public function isUppercaseString(): TrinaryLogic
 	{
-		return TrinaryLogic::createNo();
+		return TrinaryLogic::createMaybe();
 	}
 
 	public function isClassStringType(): TrinaryLogic

src/Type/Accessory/AccessoryUppercaseStringType.php

@@ -306,7 +306,7 @@ public function isLiteralString(): TrinaryLogic
 
 	public function isLowercaseString(): TrinaryLogic
 	{
-		return TrinaryLogic::createNo();
+		return TrinaryLogic::createMaybe();
 	}
 
 	public function isUppercaseString(): TrinaryLogic

tests/PHPStan/Analyser/nsrt/uppercase-string-parse.php

@@ -18,7 +18,7 @@ public function parse(string $uppercase, string $string): void
 		if (array_key_exists('foo', $a)) {
 			$value = $a['foo'];
 			if (\is_string($value)) {
-				assertType('uppercase-string', $value);
+				assertType('lowercase-string|uppercase-string', $value);
 			}
 		}
 

tests/PHPStan/Analyser/nsrt/uppercase-string-trim.php

@@ -12,12 +12,12 @@ class Foo
 	 */
 	public function doTrim(string $uppercase, string $string): void
 	{
-		assertType('uppercase-string', trim($uppercase));
-		assertType('uppercase-string', ltrim($uppercase));
-		assertType('uppercase-string', rtrim($uppercase));
-		assertType('uppercase-string', trim($uppercase, $string));
-		assertType('uppercase-string', ltrim($uppercase, $string));
-		assertType('uppercase-string', rtrim($uppercase, $string));
+		assertType('lowercase-string|uppercase-string', trim($uppercase));
+		assertType('lowercase-string|uppercase-string', ltrim($uppercase));
+		assertType('lowercase-string|uppercase-string', rtrim($uppercase));
+		assertType('lowercase-string|uppercase-string', trim($uppercase, $string));
+		assertType('lowercase-string|uppercase-string', ltrim($uppercase, $string));
+		assertType('lowercase-string|uppercase-string', rtrim($uppercase, $string));
 		assertType('string', trim($string));
 		assertType('string', ltrim($string));
 		assertType('string', rtrim($string));