fix: ensure signature function don't share identity with stubs (#505)

pmmmwh · web-flow · commit 61985e15f20d · 2021-09-14T00:03:17.000+02:00
diff --git a/lib/utils/getRefreshGlobal.js b/lib/utils/getRefreshGlobal.js
@@ -71,7 +71,9 @@ function getRefreshGlobal(
           `${refreshGlobal}.runtime.register(type, typeId);`,
         ])}`,
         '',
-        `${refreshGlobal}.signature = ${refreshGlobal}.runtime.createSignatureFunctionForTransform;`,
+        `${refreshGlobal}.signature = ${RuntimeTemplate.returningFunction(
+          `${refreshGlobal}.runtime.createSignatureFunctionForTransform()`
+        )};`,
         '',
         `${refreshGlobal}.cleanup = ${RuntimeTemplate.basicFunction('cleanupModuleId', [
           // Only cleanup if the module IDs match.
diff --git a/test/unit/getRefreshGlobal.test.js b/test/unit/getRefreshGlobal.test.js
@@ -33,7 +33,7 @@ describe('getRefreshGlobal', () => {
 			__webpack_require__.$Refresh$.runtime.register(type, typeId);
 		}
 
-		__webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;
+		__webpack_require__.$Refresh$.signature = function() { return __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform(); };
 
 		__webpack_require__.$Refresh$.cleanup = function(cleanupModuleId) {
 			if (currentModuleId === cleanupModuleId) {
@@ -94,7 +94,7 @@ describe('getRefreshGlobal', () => {
 			__webpack_require__.$Refresh$.runtime.register(type, typeId);
 		}
 
-		__webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;
+		__webpack_require__.$Refresh$.signature = () => (__webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform());
 
 		__webpack_require__.$Refresh$.cleanup = (cleanupModuleId) => {
 			if (currentModuleId === cleanupModuleId) {
diff --git a/test/unit/makeRefreshRuntimeModule.test.js b/test/unit/makeRefreshRuntimeModule.test.js
@@ -83,7 +83,7 @@ __webpack_require__.$Refresh$ = {
 			__webpack_require__.$Refresh$.runtime.register(type, typeId);
 		}
 
-		__webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;
+		__webpack_require__.$Refresh$.signature = function() { return __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform(); };
 
 		__webpack_require__.$Refresh$.cleanup = function(cleanupModuleId) {
 			if (currentModuleId === cleanupModuleId) {
@@ -162,7 +162,7 @@ __webpack_require__.$Refresh$ = {
 			__webpack_require__.$Refresh$.runtime.register(type, typeId);
 		}
 
-		__webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;
+		__webpack_require__.$Refresh$.signature = () => (__webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform());
 
 		__webpack_require__.$Refresh$.cleanup = (cleanupModuleId) => {
 			if (currentModuleId === cleanupModuleId) {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ describe('getRefreshGlobal', () => {`
`33`	`33`	`__webpack_require__.$Refresh$.runtime.register(type, typeId);`
`34`	`34`	`}`
`35`	`35`
`36`		`- __webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;`
	`36`	`+ __webpack_require__.$Refresh$.signature = function() { return __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform(); };`
`37`	`37`
`38`	`38`	`__webpack_require__.$Refresh$.cleanup = function(cleanupModuleId) {`
`39`	`39`	`if (currentModuleId === cleanupModuleId) {`
`@@ -94,7 +94,7 @@ describe('getRefreshGlobal', () => {`
`94`	`94`	`__webpack_require__.$Refresh$.runtime.register(type, typeId);`
`95`	`95`	`}`
`96`	`96`
`97`		`- __webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;`
	`97`	`+ __webpack_require__.$Refresh$.signature = () => (__webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform());`
`98`	`98`
`99`	`99`	`__webpack_require__.$Refresh$.cleanup = (cleanupModuleId) => {`
`100`	`100`	`if (currentModuleId === cleanupModuleId) {`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ __webpack_require__.$Refresh$ = {`
`83`	`83`	`__webpack_require__.$Refresh$.runtime.register(type, typeId);`
`84`	`84`	`}`
`85`	`85`
`86`		`- __webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;`
	`86`	`+ __webpack_require__.$Refresh$.signature = function() { return __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform(); };`
`87`	`87`
`88`	`88`	`__webpack_require__.$Refresh$.cleanup = function(cleanupModuleId) {`
`89`	`89`	`if (currentModuleId === cleanupModuleId) {`
`@@ -162,7 +162,7 @@ __webpack_require__.$Refresh$ = {`
`162`	`162`	`__webpack_require__.$Refresh$.runtime.register(type, typeId);`
`163`	`163`	`}`
`164`	`164`
`165`		`- __webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;`
	`165`	`+ __webpack_require__.$Refresh$.signature = () => (__webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform());`
`166`	`166`
`167`	`167`	`__webpack_require__.$Refresh$.cleanup = (cleanupModuleId) => {`
`168`	`168`	`if (currentModuleId === cleanupModuleId) {`