Add validation for negative XP cost in AnvilCraftResult

Author: ShockedPlot7560

src/block/utils/AnvilHelper.php

@@ -36,7 +36,6 @@ final class AnvilHelper{
 	 * Returns null if the operation can't do anything.
 	 */
 	public static function calculateResult(Item $base, Item $material, ?string $customName, bool $isCreative) : ?AnvilCraftResult{
-
 		$recipe = Server::getInstance()->getCraftingManager()->matchAnvilRecipe($base, $material);
 		if($recipe === null){
 			return null;

src/crafting/AnvilCraftResult.php

@@ -30,13 +30,18 @@
  */
 final class AnvilCraftResult{
 	/**
+	 * @param int $xpCost The experience points cost required to craft the output item. (positive integer, 0 means no cost)
+	 * @param Item $output The item given as output of the crafting process.
 	 * @param Item|null $sacrificeResult If the given item is considered as null (count <= 0), the value will be set to null.
 	 */
 	public function __construct(
 		private int $xpCost,
 		private Item $output,
 		private ?Item $sacrificeResult
 	){
+		if($this->xpCost < 0){
+			throw new \InvalidArgumentException("XP cost cannot be negative");
+		}
 		if($this->sacrificeResult !== null && $this->sacrificeResult->isNull()){
 			$this->sacrificeResult = null;
 		}

src/crafting/CraftingManagerFromDataHelper.php

@@ -211,7 +211,7 @@ public static function make(string $directoryPath) : CraftingManager{
 		$result = new CraftingManager();
 
 		foreach(self::loadJsonArrayOfObjectsFile(Path::join($directoryPath, 'shapeless_crafting.json'), ShapelessRecipeData::class) as $recipe){
-			$recipeType = match ($recipe->block) {
+			$recipeType = match($recipe->block){
 				"crafting_table" => ShapelessRecipeType::CRAFTING,
 				"stonecutter" => ShapelessRecipeType::STONECUTTER,
 				"smithing_table" => ShapelessRecipeType::SMITHING,
@@ -272,7 +272,7 @@ public static function make(string $directoryPath) : CraftingManager{
 			));
 		}
 		foreach(self::loadJsonArrayOfObjectsFile(Path::join($directoryPath, 'smelting.json'), FurnaceRecipeData::class) as $recipe){
-			$furnaceType = match ($recipe->block) {
+			$furnaceType = match ($recipe->block){
 				"furnace" => FurnaceType::FURNACE,
 				"blast_furnace" => FurnaceType::BLAST_FURNACE,
 				"smoker" => FurnaceType::SMOKER,

src/crafting/ItemCombineRecipe.php

@@ -87,8 +87,8 @@ public function getResultFor(Item $input, Item $material) : ?AnvilCraftResult{
 				$xpCost += (int) floor($costAddition * $levelDifference);
 				$result->addEnchantment($instance);
 
-				$xpCost += 2 ** $input->getAnvilRepairCost() - 1;
-				$xpCost += 2 ** $material->getAnvilRepairCost() - 1;
+				$xpCost += (2 ** $input->getAnvilRepairCost()) - 1;
+				$xpCost += (2 ** $material->getAnvilRepairCost()) - 1;
 				$result->setAnvilRepairCost(
 					max($result->getAnvilRepairCost(), $material->getAnvilRepairCost()) + 1
 				);

src/inventory/transaction/AnvilTransaction.php

@@ -145,7 +145,7 @@ public function execute() : void{
 
 	protected function callExecuteEvent() : bool{
 		if($this->baseItem === null){
-			throw new AssumptionFailedError("Expected that baseItem are not null before executing the event");
+			throw new AssumptionFailedError("Expected that baseItem is not null before executing the event");
 		}
 
 		$ev = new PlayerUseAnvilEvent($this->source, $this->baseItem, $this->materialItem, $this->expectedResult->getOutput(), $this->customName, $this->expectedResult->getXpCost());