-
Notifications
You must be signed in to change notification settings - Fork 768
Open
Labels
bugSomething isn't workingSomething isn't working
Description
three
version: 0.178.0@react-three/fiber
version: 9.2.0@react-three/drei
version: 10.5.1
Problem description:
If controls.dispose()
is called while mouse is down, controls will not register mouse up and get stuck waiting for pointer to be removed here three-stdlib.controls.OrbitControls.onPointerDown
Relevant code:
In Sandbox, inside Controls component there are handleChange
and badHandleChange
badHandleChage breaks MapControls, but doesn't affect OrbitControls
Suggested solution:
I'm not quite sure, here are my ideas:
- drei.core.MapControls should have similar hook structure to drei.core.OrbitContorls.
controls.dispose()
should be called with full recreation of underlying class fromthree-stdlib.controls
, otherwise there is a risk to break internal state and get stuck
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working