test(react/vanilla-utils/atomWithObservable): add test for 'Symbol.observable' interop protocol#3253
Open
sukvvon wants to merge 1 commit intopmndrs:mainfrom
Open
Conversation
…servable' interop protocol
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/CLE9UEURE |
See documentations for usage instructions.
dai-shi
reviewed
Mar 4, 2026
| it('count state with Symbol.observable', () => { | ||
| const subject = new BehaviorSubject(1) | ||
| const observable = { | ||
| subscribe: subject.subscribe.bind(subject), |
Member
There was a problem hiding this comment.
Shouldn't we remove this to test the behavior?
btw, I'm not sure if we should preserve supporting Symbol.observable in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
N/A
Summary
atomWithObservablewithSymbol.observableinterop protocolatomWithObservablerecognizes and subscribes to the observable returned by[Symbol.observable]()Symbol.observabledetection and observable replacement path (line 83)Check List
pnpm run fixfor formatting and linting code and docs