Skip to content

Commit 49768e1

Browse files
author
v 1 r t l
authored
Merge pull request #200 from njm222/master
fix: missing effect type definitions
2 parents 2a78d95 + ac998f6 commit 49768e1

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/effects/GodRays.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { GodRaysEffect } from 'postprocessing'
2-
import React, { Ref, forwardRef, useMemo, useContext } from 'react'
2+
import React, { Ref, forwardRef, useMemo, useContext, useLayoutEffect } from 'react'
33
import { Mesh, Points } from 'three'
44
import { EffectComposerContext } from '../EffectComposer'
5-
import { useLayoutEffect } from 'react'
65
import { resolveRef } from '../util'
76

87
type GodRaysProps = ConstructorParameters<typeof GodRaysEffect>[2] & {

src/util.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,8 @@ export type EffectProps<T extends EffectConstructor> = ReactThreeFiber.Node<
2121
let i = 0
2222
const components = new WeakMap<EffectConstructor, React.ExoticComponent<any> | string>()
2323

24-
export const wrapEffect = <T extends EffectConstructor, P extends EffectProps<T> = EffectProps<T>>(
25-
effect: T,
26-
defaults?: P
27-
) =>
28-
/* @__PURE__ */ React.forwardRef<T, P>(function Effect(
24+
export const wrapEffect = <T extends EffectConstructor>(effect: T, defaults?: EffectProps<T>) =>
25+
/* @__PURE__ */ React.forwardRef<T, EffectProps<T>>(function Effect(
2926
{ blendFunction = defaults?.blendFunction, opacity = defaults?.opacity, ...props },
3027
ref
3128
) {

0 commit comments

Comments
 (0)