Skip to content

Commit 72bfe72

Browse files
authored
Merge pull request #224 from CodyJasonBennett/fix/chromatic-offset
fix(ChromaticAbberation): offset prop
2 parents 41231d2 + 8242715 commit 72bfe72

File tree

1 file changed

+3
-17
lines changed

1 file changed

+3
-17
lines changed

src/effects/ChromaticAberration.tsx

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,5 @@
1-
import React, { Ref, forwardRef, useMemo } from 'react'
21
import { ChromaticAberrationEffect } from 'postprocessing'
3-
import { ReactThreeFiber } from '@react-three/fiber'
4-
import { useVector2 } from '../util'
2+
import { type EffectProps, wrapEffect } from '../util'
53

6-
// type for function args should use constructor args
7-
export type ChromaticAberrationProps = ConstructorParameters<typeof ChromaticAberrationEffect>[0] &
8-
Partial<{
9-
offset: ReactThreeFiber.Vector2
10-
}>
11-
12-
export const ChromaticAberration = forwardRef(function ChromaticAberration(
13-
props: ChromaticAberrationProps,
14-
ref: Ref<ChromaticAberrationEffect>
15-
) {
16-
const offset = useVector2(props, 'offset')
17-
const effect = useMemo(() => new ChromaticAberrationEffect({ ...props, offset }), [offset, props])
18-
return <primitive ref={ref} object={effect} dispose={null} />
19-
})
4+
export type ChromaticAberrationProps = EffectProps<typeof ChromaticAberrationEffect>
5+
export const ChromaticAberration = wrapEffect(ChromaticAberrationEffect)

0 commit comments

Comments
 (0)