Skip to content

Commit c563a8b

Browse files
fix(Glitch): dispose on unmount
1 parent 693f5e0 commit c563a8b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/effects/Glitch.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Vector2 } from 'three'
22
import { GlitchEffect, GlitchMode } from 'postprocessing'
3-
import { Ref, forwardRef, useMemo, useLayoutEffect } from 'react'
3+
import { Ref, forwardRef, useMemo, useLayoutEffect, useEffect } from 'react'
44
import { ReactThreeFiber, useThree } from '@react-three/fiber'
55
import { useVector2 } from '../util'
66

@@ -31,5 +31,10 @@ export const Glitch = forwardRef<GlitchEffect, GlitchProps>(function Glitch(
3131
effect.mode = active ? props.mode || GlitchMode.SPORADIC : GlitchMode.DISABLED
3232
invalidate()
3333
}, [active, effect, invalidate, props.mode])
34+
useEffect(() => {
35+
return () => {
36+
effect.dispose()
37+
}
38+
}, [effect])
3439
return <primitive ref={ref} object={effect} dispose={null} />
3540
})

0 commit comments

Comments
 (0)