Skip to content

Commit 5bf7324

Browse files
authored
fix(OrbitControls): upstream fixes (#365)
1 parent 430ffd7 commit 5bf7324

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/controls/OrbitControls.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -408,18 +408,18 @@ class OrbitControls extends EventDispatcher {
408408
scope.domElement.style.touchAction = 'none'
409409
scope.domElement.addEventListener('contextmenu', onContextMenu)
410410
scope.domElement.addEventListener('pointerdown', onPointerDown)
411-
scope.domElement.addEventListener('pointercancel', onPointerCancel)
411+
scope.domElement.addEventListener('pointercancel', onPointerUp)
412412
scope.domElement.addEventListener('wheel', onMouseWheel)
413413
}
414414

415415
this.dispose = (): void => {
416416
// Enabling touch scroll
417-
if(scope.domElement) {
417+
if (scope.domElement) {
418418
scope.domElement.style.touchAction = 'auto'
419419
}
420420
scope.domElement?.removeEventListener('contextmenu', onContextMenu)
421421
scope.domElement?.removeEventListener('pointerdown', onPointerDown)
422-
scope.domElement?.removeEventListener('pointercancel', onPointerCancel)
422+
scope.domElement?.removeEventListener('pointercancel', onPointerUp)
423423
scope.domElement?.removeEventListener('wheel', onMouseWheel)
424424
scope.domElement?.ownerDocument.removeEventListener('pointermove', onPointerMove)
425425
scope.domElement?.ownerDocument.removeEventListener('pointerup', onPointerUp)
@@ -858,10 +858,6 @@ class OrbitControls extends EventDispatcher {
858858
state = STATE.NONE
859859
}
860860

861-
function onPointerCancel(event: PointerEvent) {
862-
removePointer(event)
863-
}
864-
865861
function onMouseDown(event: MouseEvent) {
866862
let mouseAction
867863

0 commit comments

Comments
 (0)