fix(LineSegmentsGeometry): dynamic interleave offset (#336)

damiponce · web-flow · commit 6a37a195b377 · 2024-01-11T19:00:25.000-06:00
diff --git a/src/lines/LineSegmentsGeometry.js b/src/lines/LineSegmentsGeometry.js
@@ -86,7 +86,7 @@ class LineSegmentsGeometry extends InstancedBufferGeometry {
     const instanceColorBuffer = new InstancedInterleavedBuffer(colors, itemSize * 2, 1) // rgb(a), rgb(a)
 
     this.setAttribute('instanceColorStart', new InterleavedBufferAttribute(instanceColorBuffer, itemSize, 0)) // rgb(a)
-    this.setAttribute('instanceColorEnd', new InterleavedBufferAttribute(instanceColorBuffer, itemSize, 3)) // rgb(a)
+    this.setAttribute('instanceColorEnd', new InterleavedBufferAttribute(instanceColorBuffer, itemSize, itemSize)) // rgb(a)
 
     return this
   }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ class LineSegmentsGeometry extends InstancedBufferGeometry {`
`86`	`86`	`const instanceColorBuffer = new InstancedInterleavedBuffer(colors, itemSize * 2, 1) // rgb(a), rgb(a)`
`87`	`87`
`88`	`88`	`this.setAttribute('instanceColorStart', new InterleavedBufferAttribute(instanceColorBuffer, itemSize, 0)) // rgb(a)`
`89`		`- this.setAttribute('instanceColorEnd', new InterleavedBufferAttribute(instanceColorBuffer, itemSize, 3)) // rgb(a)`
	`89`	`+ this.setAttribute('instanceColorEnd', new InterleavedBufferAttribute(instanceColorBuffer, itemSize, itemSize)) // rgb(a)`
`90`	`90`
`91`	`91`	`return this`
`92`	`92`	`}`