chore: Implementing PR feedback

Author: taeuscherpferd

packages/react/handle/package.json

@@ -35,8 +35,7 @@
     "zustand": "^4.5.2"
   },
   "devDependencies": {
-    "@react-three/fiber": "rc",
-    "jsdoc-to-markdown": "^9.1.1"
+    "@react-three/fiber": "rc"
   },
   "scripts": {
     "build": "tsc",

packages/react/xr/src/controller.tsx

@@ -101,9 +101,7 @@ export const XRControllerModel = forwardRef<Object3D, XRControllerModelOptions>(
 const LoadXRControllerLayoutSymbol = Symbol('loadXRControllerLayout')
 
 /**
- * Hook for loading a controller layout, which contains info about the controller model and its buttons / controls.
- * For xr controllers provided through WebXR, the layout is loaded and provided through the controller state automatically.
- * Therefore, this hook's purpose is for building controller demos/tutorials.
+ * For rendering a controller that is not included in WebXR. (e.g controller tutorials/demos)
  *
  * @param profileIds
  * @param handedness

packages/react/xr/src/hooks.ts

@@ -6,10 +6,13 @@ import { useXR } from './xr.js'
 /**
  * Used to track the hover state of a 3D object.
  *
- * @param  ref The reference to the 3D object.
- * @param  onChange `(hover: boolean, event: PointerEvent) => void` Callback for hover state changes.
- * @returns Returns the hover state if no callback is provided.
+ * @param ref The reference to the 3D object.
+ * @param onChange `(hover: boolean, event: PointerEvent) => void` Callback for hover state changes.
  */
+export function useHover(ref: RefObject<Object3D | null>): boolean
+
+export function useHover(ref: RefObject<Object3D | null>, onChange: (hover: boolean, event: PointerEvent) => void): void
+
 export function useHover(
   ref: RefObject<Object3D | null>,
   onChange?: (hover: boolean, event: PointerEvent) => void,
@@ -76,7 +79,7 @@ export function useInitRoomCapture() {
  * @param {XRSessionMode} mode - The `XRSessionMode` to check against.
  * @param {(error: any) => void} [onError] - Callback executed when an error occurs.
  */
-export function useXRSessionModeSupported(mode: XRSessionMode, onError?: (error: any) => void): boolean | undefined {
+export function useXRSessionModeSupported(mode: XRSessionMode, onError?: (error: any) => void) {
   const onErrorRef = useRef(onError)
   onErrorRef.current = onError
   const [subscribe, getSnapshot] = useMemo(() => {

packages/react/xr/src/space.tsx

@@ -53,9 +53,7 @@ export const XRSpace = forwardRef<
 /**
  * A combined type of all XRSpace types
  * @see [XRReferenceSpaceType](https://developer.mozilla.org/en-US/docs/Web/API/XRReferenceSpaceType)
- * @see [XRInputSourceSpaceType](https://developer.mozilla.org/en-US/docs/Web/API/XRInputSourceSpaceType)
- * @see [XRHandJointSpaceType](https://developer.mozilla.org/en-US/docs/Web/API/XRHandJointSpaceType)
- * @see [XRBodyJointSpaceType](https://developer.mozilla.org/en-US/docs/Web/API/XRBodyJointSpaceType)
+ * @see [XRHandJointSpaceType](https://immersive-web.github.io/webxr-hand-input/#xrhand-interface)
  */
 export type XRSpaceType = XRReferenceSpaceType | XRInputSourceSpaceType | XRHandJointSpaceType | XRBodyJointSpaceType
 
@@ -241,10 +239,11 @@ export function useGetXRSpaceMatrix(space: XRSpace | undefined) {
  * Hook that applies the transformation of the provided xr space to the provided object reference
  *
  * @param onFrame Optional callback that gets executed after the matrix of the reference object was updated
+ * @param ref.current A react ref object that points to the object that the XRSpaceMatrix should be applied to
  * @requires matrixAutoUpdate to be disabled for the referenced object
  */
 export function useApplyXRSpaceMatrix(
-  ref: React.RefObject<Object3D | null>,
+  ref: { current?: Group | null },
   space: XRSpace | undefined,
   onFrame?: (state: RootState, delta: number, frame: XRFrame | undefined) => void,
 ): void {