Skip to content

Commit 85d781f

Browse files
committed
ch4/progress: Improve global progress conditional
When global progress is triggered we should ignore the progress state flags and just call every progress function.
1 parent 4fea2de commit 85d781f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/mpid/ch4/src/ch4_progress.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ MPL_STATIC_INLINE_PREFIX int MPIDI_do_global_progress(void)
5858
#ifdef MPIDI_CH4_DIRECT_NETMOD
5959
#define MPIDI_PROGRESS(vci, is_global) \
6060
do { \
61-
if (state->flag & MPIDI_PROGRESS_NM && (is_global || !made_progress)) { \
61+
if (is_global || (state->flag & MPIDI_PROGRESS_NM && !made_progress)) { \
6262
MPIDI_THREAD_CS_ENTER_VCI_OPTIONAL(vci); \
6363
mpi_errno = MPIDI_NM_progress(vci, &made_progress); \
6464
MPIDI_THREAD_CS_EXIT_VCI_OPTIONAL(vci); \
@@ -69,13 +69,13 @@ MPL_STATIC_INLINE_PREFIX int MPIDI_do_global_progress(void)
6969
#else
7070
#define MPIDI_PROGRESS(vci, is_global) \
7171
do { \
72-
if (state->flag & MPIDI_PROGRESS_SHM && (is_global || !made_progress)) { \
72+
if (is_global || (state->flag & MPIDI_PROGRESS_SHM && !made_progress)) { \
7373
MPID_THREAD_CS_ENTER(VCI, MPIDI_VCI_LOCK(vci)); \
7474
mpi_errno = MPIDI_SHM_progress(vci, &made_progress); \
7575
MPID_THREAD_CS_EXIT(VCI, MPIDI_VCI_LOCK(vci)); \
7676
MPIR_ERR_CHECK(mpi_errno); \
7777
} \
78-
if (state->flag & MPIDI_PROGRESS_NM && (is_global || !made_progress)) { \
78+
if (is_global || (state->flag & MPIDI_PROGRESS_NM && !made_progress)) { \
7979
MPIDI_THREAD_CS_ENTER_VCI_OPTIONAL(vci); \
8080
mpi_errno = MPIDI_NM_progress(vci, &made_progress); \
8181
MPIDI_THREAD_CS_EXIT_VCI_OPTIONAL(vci); \

0 commit comments

Comments
 (0)