[Data Streams] Fix forward-compatibility test failures (elastic#223129)

Fixes elastic#221224

## Summary

This PR fixes the forward-compatibility test for index mode, which
failed because the index mode was added to Get Data Streams API in 8.19
and 9.1 (see elastic/elasticsearch#122486), so
if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as
"Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate
file, and only run it for Es versions 8.19 or 9.1+.

Author: ElenaStoeva

x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab.ts

@@ -17,12 +17,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
   const security = getService('security');
   const testSubjects = getService('testSubjects');
 
-  enum INDEX_MODE {
-    STANDARD = 'Standard',
-    LOGSDB = 'LogsDB',
-    TIME_SERIES = 'Time series',
-  }
-
   const TEST_DS_NAME_1 = 'test-ds-1';
   const TEST_DS_NAME_2 = 'test-ds-2';
   const TEST_DATA_STREAM_NAMES = [TEST_DS_NAME_1, TEST_DS_NAME_2];
@@ -99,48 +93,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
       await testSubjects.click('closeDetailsButton');
     });
 
-    describe('shows the correct index mode in the details flyout', function () {
-      it('standard index mode', async () => {
-        // Open details flyout of existing data stream - it has standard index mode
-        await pageObjects.indexManagement.clickDataStreamNameLink(TEST_DS_NAME_1);
-        // Check that index mode detail exists and its label is "Standard"
-        expect(await testSubjects.exists('indexModeDetail')).to.be(true);
-        expect(await testSubjects.getVisibleText('indexModeDetail')).to.be('Standard');
-        // Close flyout
-        await testSubjects.click('closeDetailsButton');
-      });
-
-      it('logsdb index mode', async () => {
-        // Create an index template with a logsdb index mode
-        await es.indices.putIndexTemplate({
-          name: `logsdb_index_template`,
-          index_patterns: ['test-logsdb'],
-          data_stream: {},
-          template: {
-            settings: { mode: 'logsdb' },
-          },
-        });
-        // Create a data stream matching the index pattern of the index template above
-        await es.indices.createDataStream({
-          name: 'test-logsdb',
-        });
-        await browser.refresh();
-        // Open details flyout of data stream
-        await pageObjects.indexManagement.clickDataStreamNameLink('test-logsdb');
-        // Check that index mode detail exists and its label is "LogsDB"
-        expect(await testSubjects.exists('indexModeDetail')).to.be(true);
-        expect(await testSubjects.getVisibleText('indexModeDetail')).to.be('LogsDB');
-        // Close flyout
-        await testSubjects.click('closeDetailsButton');
-        // Delete data stream and index template
-        await es.indices.deleteDataStream({ name: 'test-logsdb' });
-        await es.indices.deleteIndexTemplate({
-          name: `logsdb_index_template`,
-        });
-        await testSubjects.click('reloadButton');
-      });
-    });
-
     describe('data retention modal', function () {
       describe('from details panel', function () {
         it('allows to update data retention', async () => {
@@ -230,171 +182,5 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         });
       });
     });
-
-    describe('Modify data streams index mode', () => {
-      const TEST_DS_NAME = 'test-ds';
-      const setIndexModeTemplate = async (settings: object) => {
-        await es.indices.putIndexTemplate({
-          name: `index_template_${TEST_DS_NAME}`,
-          index_patterns: [TEST_DS_NAME],
-          data_stream: {},
-          template: {
-            settings,
-          },
-        });
-        await es.indices.createDataStream({
-          name: TEST_DS_NAME,
-        });
-        await testSubjects.click('reloadButton');
-      };
-
-      const verifyIndexModeIsOrigin = async (indexModeName: string) => {
-        // Open details flyout of data stream
-        await pageObjects.indexManagement.clickDataStreamNameLink(TEST_DS_NAME);
-        // Check that index mode detail exists and its label is origin
-        expect(await testSubjects.exists('indexModeDetail')).to.be(true);
-        expect(await testSubjects.getVisibleText('indexModeDetail')).to.be(indexModeName);
-        // Close flyout
-        await testSubjects.click('closeDetailsButton');
-        // Navigate to the templates tab
-        await pageObjects.indexManagement.changeTabs('templatesTab');
-        await pageObjects.header.waitUntilLoadingHasFinished();
-        // Edit template
-        await pageObjects.indexManagement.clickIndexTemplateNameLink(
-          `index_template_${TEST_DS_NAME}`
-        );
-        await testSubjects.click('manageTemplateButton');
-        await testSubjects.click('editIndexTemplateButton');
-
-        // Verify index mode is origin
-        expect(await testSubjects.getVisibleText('indexModeField')).to.be(indexModeName);
-      };
-
-      const changeIndexMode = async (indexModeSelector: string) => {
-        // Modify index mode
-        await testSubjects.click('indexModeField');
-        await testSubjects.click(indexModeSelector);
-      };
-
-      const verifyModeHasBeenChanged = async (indexModeName: string) => {
-        expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
-
-        // Click update template
-        await pageObjects.indexManagement.clickNextButton();
-        await pageObjects.header.waitUntilLoadingHasFinished();
-
-        // Verify index mode and close detail tab
-        expect(await testSubjects.getVisibleText('indexModeValue')).to.be(indexModeName);
-        await testSubjects.click('closeDetailsButton');
-
-        // Perform rollover so that index mode of data stream is updated
-        await es.indices.rollover({
-          alias: TEST_DS_NAME,
-        });
-
-        // Navigate to the data streams tab
-        await pageObjects.indexManagement.changeTabs('data_streamsTab');
-        await pageObjects.header.waitUntilLoadingHasFinished();
-
-        // Open data stream
-        await pageObjects.indexManagement.clickDataStreamNameLink(TEST_DS_NAME);
-        // Check that index mode detail exists and its label is destination index mode
-        expect(await testSubjects.exists('indexModeDetail')).to.be(true);
-        expect(await testSubjects.getVisibleText('indexModeDetail')).to.be(indexModeName);
-        // Close flyout
-        await testSubjects.click('closeDetailsButton');
-      };
-
-      afterEach(async () => {
-        await log.debug('Cleaning up created data stream');
-
-        try {
-          await es.indices.deleteDataStream({ name: TEST_DS_NAME });
-          await es.indices.deleteIndexTemplate({
-            name: `index_template_${TEST_DS_NAME}`,
-          });
-        } catch (e) {
-          log.debug('Error deleting test data stream');
-          throw e;
-        }
-      });
-
-      it('allows to upgrade data stream from standard to logsdb index mode', async () => {
-        await setIndexModeTemplate({
-          mode: 'standard',
-        });
-        await verifyIndexModeIsOrigin(INDEX_MODE.STANDARD);
-
-        await changeIndexMode('index_mode_logsdb');
-        // Navigate to the last step of the wizard
-        await testSubjects.click('formWizardStep-5');
-        await pageObjects.header.waitUntilLoadingHasFinished();
-
-        await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
-      });
-
-      it('allows to downgrade data stream from logsdb to standard index mode', async () => {
-        await setIndexModeTemplate({
-          mode: 'logsdb',
-        });
-        await verifyIndexModeIsOrigin(INDEX_MODE.LOGSDB);
-
-        await changeIndexMode('index_mode_standard');
-        // Navigate to the last step of the wizard
-        await testSubjects.click('formWizardStep-5');
-        await pageObjects.header.waitUntilLoadingHasFinished();
-
-        await verifyModeHasBeenChanged(INDEX_MODE.STANDARD);
-      });
-
-      // Fails because of https://github.com/elastic/elasticsearch/issues/126473
-      it.skip('allows to upgrade data stream from time series to logsdb index mode', async () => {
-        await setIndexModeTemplate({
-          mode: 'time_series',
-          routing_path: 'test',
-        });
-        await verifyIndexModeIsOrigin(INDEX_MODE.TIME_SERIES);
-
-        await changeIndexMode('index_mode_logsdb');
-
-        await testSubjects.click('formWizardStep-2');
-        await pageObjects.header.waitUntilLoadingHasFinished();
-        // Modify Index settings
-        await testSubjects.setValue('kibanaCodeEditor', '{}', {
-          clearWithKeyboard: true,
-        });
-        // Navigate to the last step of the wizard
-        await testSubjects.click('formWizardStep-5');
-        await pageObjects.header.waitUntilLoadingHasFinished();
-
-        await verifyModeHasBeenChanged(INDEX_MODE.LOGSDB);
-      });
-
-      // Fails because of https://github.com/elastic/elasticsearch/issues/126473
-      it.skip('allows to downgrade data stream from logsdb to time series index mode', async () => {
-        await setIndexModeTemplate({
-          mode: 'logsdb',
-        });
-        await verifyIndexModeIsOrigin(INDEX_MODE.LOGSDB);
-
-        await changeIndexMode('index_mode_time_series');
-
-        await testSubjects.click('formWizardStep-2');
-        await pageObjects.header.waitUntilLoadingHasFinished();
-        // Modify Index settings
-        await testSubjects.setValue(
-          'kibanaCodeEditor',
-          JSON.stringify({ index: { mode: 'time_series', routing_path: 'test' } }),
-          {
-            clearWithKeyboard: true,
-          }
-        );
-        // Navigate to the last step of the wizard
-        await testSubjects.click('formWizardStep-5');
-        await pageObjects.header.waitUntilLoadingHasFinished();
-
-        await verifyModeHasBeenChanged(INDEX_MODE.TIME_SERIES);
-      });
-    });
   });
 };

x-pack/test/functional/apps/index_management/data_streams_tab/index.ts

@@ -10,5 +10,6 @@ import { FtrProviderContext } from '../../../ftr_provider_context';
 export default ({ loadTestFile }: FtrProviderContext) => {
   describe('Index Management: data streams tab', function () {
     loadTestFile(require.resolve('./data_streams_tab'));
+    loadTestFile(require.resolve('./index_mode'));
   });
 };