Skip to content

Commit 6fcac6c

Browse files
[9.0] [Data Views] Fix detail page header not being full width (elastic#236441) (elastic#236950)
# Backport This will backport the following commits from `main` to `9.0`: - [[Data Views] Fix detail page header not being full width (elastic#236441)](elastic#236441) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Damian Polewski","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-09-29T11:08:56Z","message":"[Data Views] Fix detail page header not being full width (elastic#236441)\n\n## Summary\n\nCloses elastic#233305\n\nThis PR fixes an issue where Data Views Detail page header was not\nshowing at full width of page template.","sha":"887d2090a09501e57074e08e23d4d85186a91bb2","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data Views","Team:Kibana Management","release_note:skip","backport missing","backport:all-open","v9.2.0"],"title":"[Data Views] Fix detail page header not being full width","number":236441,"url":"https://github.com/elastic/kibana/pull/236441","mergeCommit":{"message":"[Data Views] Fix detail page header not being full width (elastic#236441)\n\n## Summary\n\nCloses elastic#233305\n\nThis PR fixes an issue where Data Views Detail page header was not\nshowing at full width of page template.","sha":"887d2090a09501e57074e08e23d4d85186a91bb2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236441","number":236441,"mergeCommit":{"message":"[Data Views] Fix detail page header not being full width (elastic#236441)\n\n## Summary\n\nCloses elastic#233305\n\nThis PR fixes an issue where Data Views Detail page header was not\nshowing at full width of page template.","sha":"887d2090a09501e57074e08e23d4d85186a91bb2"}},{"url":"https://github.com/elastic/kibana/pull/236946","number":236946,"branch":"9.1","state":"OPEN"}]}] BACKPORT-->
1 parent c3dea63 commit 6fcac6c

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/platform/plugins/shared/data_view_management/public/components/edit_index_pattern/edit_index_pattern.tsx

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { withRouter, RouteComponentProps, useLocation } from 'react-router-dom';
1212
import {
1313
EuiFlexGroup,
1414
EuiFlexItem,
15-
EuiHorizontalRule,
1615
EuiSpacer,
1716
EuiBadge,
1817
EuiCallOut,
@@ -189,20 +188,20 @@ export const EditIndexPattern = withRouter(
189188
return (
190189
<div data-test-subj="editIndexPattern" role="region" aria-label={headingAriaLabel}>
191190
{dataView && (
192-
<IndexHeader
193-
indexPattern={dataView}
194-
setDefault={() => dataViewMgmtService.setDefaultDataView()}
195-
editIndexPatternClick={editPattern}
196-
deleteIndexPatternClick={() =>
197-
removeHandler(
198-
[dataView as RemoveDataViewProps],
199-
deleteModalMsg([dataView as RemoveDataViewProps], Boolean(dataView.namespaces))
200-
)
201-
}
202-
defaultIndex={defaultIndex}
203-
canSave={userEditPermission}
204-
>
205-
<EuiHorizontalRule margin="none" />
191+
<>
192+
<IndexHeader
193+
indexPattern={dataView}
194+
setDefault={() => dataViewMgmtService.setDefaultDataView()}
195+
editIndexPatternClick={editPattern}
196+
deleteIndexPatternClick={() =>
197+
removeHandler(
198+
[dataView as RemoveDataViewProps],
199+
deleteModalMsg([dataView as RemoveDataViewProps], Boolean(dataView.namespaces))
200+
)
201+
}
202+
defaultIndex={defaultIndex}
203+
canSave={userEditPermission}
204+
/>
206205
<EuiSpacer size="l" />
207206
<EuiFlexGroup wrap gutterSize="l" alignItems="center">
208207
{Boolean(indexPattern.title) && (
@@ -274,7 +273,7 @@ export const EditIndexPattern = withRouter(
274273
</EuiCallOut>
275274
</>
276275
)}
277-
</IndexHeader>
276+
</>
278277
)}
279278
<EuiSpacer size="xl" />
280279
{dataView && (

src/platform/plugins/shared/data_view_management/public/components/edit_index_pattern/index_header/index_header.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ export const IndexHeader: FC<PropsWithChildren<IndexHeaderProps>> = ({
5959
return (
6060
<EuiPageHeader
6161
pageTitle={<span data-test-subj="indexPatternTitle">{indexPattern.getName()}</span>}
62+
bottomBorder
6263
rightSideItems={[
6364
canSave && (
6465
<EuiButton

0 commit comments

Comments
 (0)