feat: accept MarketOutcome object in all outcome-based SDK methods

Standardize the MarketOutcome shorthand pattern (already used by
createOrder/buildOrder) across fetchOrderBook, fetchOHLCV, fetchTrades,
watchOrderBook, and watchTrades in both Python and TypeScript SDKs.
Users can now pass market.yes directly instead of market.yes.outcomeId.

Author: realfishsam

sdks/python/pmxt/client.py

@@ -48,6 +48,13 @@
 from .server_manager import ServerManager
 
 
+def _resolve_outcome_id(value: Union[str, "MarketOutcome"]) -> str:
+    """Extract outcome_id string from a MarketOutcome or pass through a string."""
+    if isinstance(value, str):
+        return value
+    return value.outcome_id
+
+
 def _convert_outcome(raw: Dict[str, Any]) -> MarketOutcome:
     """Convert raw API response to MarketOutcome."""
     return MarketOutcome(
@@ -606,8 +613,9 @@ def fetch_event(self, params: Optional[dict] = None, **kwargs) -> UnifiedEvent:
         except Exception as e:
             raise self._parse_api_exception(e) from None
 
-    def fetch_order_book(self, id: str) -> OrderBook:
+    def fetch_order_book(self, id: Union[str, "MarketOutcome"]) -> OrderBook:
         try:
+            id = _resolve_outcome_id(id)
             args = []
             args.append(id)
             body: dict = {"args": args}
@@ -1012,7 +1020,7 @@ def filter_events(
 
     def fetch_ohlcv(
         self,
-        outcome_id: str,
+        outcome_id: Union[str, "MarketOutcome"],
         resolution: Optional[str] = None,
         limit: Optional[int] = None,
         start: Optional[datetime] = None,
@@ -1027,7 +1035,7 @@ def fetch_ohlcv(
         - Kalshi: outcome.outcome_id is the Market Ticker
 
         Args:
-            outcome_id: Outcome ID (from market.outcomes[].outcome_id)
+            outcome_id: Outcome ID (from market.outcomes[].outcome_id), or a MarketOutcome object
             resolution: Candle resolution (e.g., "1h", "1d")
             limit: Maximum number of candles to return
             start: Start datetime for historical data
@@ -1047,6 +1055,7 @@ def fetch_ohlcv(
             ... )
         """
         try:
+            outcome_id = _resolve_outcome_id(outcome_id)
             params_dict = {}
             if resolution:
                 params_dict["resolution"] = resolution
@@ -1077,7 +1086,7 @@ def fetch_ohlcv(
 
     def fetch_trades(
         self,
-        outcome_id: str,
+        outcome_id: Union[str, "MarketOutcome"],
         limit: Optional[int] = None,
         since: Optional[int] = None,
         **kwargs
@@ -1100,6 +1109,7 @@ def fetch_trades(
             >>> trades = exchange.fetch_trades(outcome_id, limit=50)
         """
         try:
+            outcome_id = _resolve_outcome_id(outcome_id)
             params_dict = {}
             if limit:
                 params_dict["limit"] = limit
@@ -1126,7 +1136,7 @@ def fetch_trades(
 
     # WebSocket Streaming Methods
 
-    def watch_order_book(self, outcome_id: str, limit: Optional[int] = None) -> OrderBook:
+    def watch_order_book(self, outcome_id: Union[str, "MarketOutcome"], limit: Optional[int] = None) -> OrderBook:
         """
         Watch real-time order book updates via WebSocket.
 
@@ -1148,6 +1158,7 @@ def watch_order_book(self, outcome_id: str, limit: Optional[int] = None) -> Orde
             ...     print(f"Best ask: {order_book.asks[0].price}")
         """
         try:
+            outcome_id = _resolve_outcome_id(outcome_id)
             args = [outcome_id]
             if limit is not None:
                 args.append(limit)
@@ -1173,7 +1184,7 @@ def watch_order_book(self, outcome_id: str, limit: Optional[int] = None) -> Orde
 
     def watch_trades(
         self,
-        outcome_id: str,
+        outcome_id: Union[str, "MarketOutcome"],
         address: Optional[str] = None,
         since: Optional[int] = None,
         limit: Optional[int] = None,
@@ -1201,6 +1212,7 @@ def watch_trades(
             ...         print(f"Trade: {trade.price} @ {trade.amount}")
         """
         try:
+            outcome_id = _resolve_outcome_id(outcome_id)
             args = [outcome_id]
             if address is not None:
                 args.append(address)

sdks/typescript/pmxt/client.ts

@@ -45,6 +45,15 @@ import { ServerManager } from "./server-manager.js";
 import { buildArgsWithOptionalOptions } from "./args.js";
 import { PmxtError, fromServerError } from "./errors.js";
 
+/**
+ * Resolve a MarketOutcome shorthand to a plain outcome ID string.
+ * Accepts either a raw string ID or a MarketOutcome object.
+ */
+function resolveOutcomeId(input: string | MarketOutcome): string {
+    if (typeof input === 'string') return input;
+    return input.outcomeId;
+}
+
 // Converter functions
 function convertMarket(raw: any): UnifiedMarket {
     const outcomes: MarketOutcome[] = (raw.outcomes || []).map((o: any) => ({
@@ -544,11 +553,12 @@ export abstract class Exchange {
         }
     }
 
-    async fetchOrderBook(id: string): Promise<OrderBook> {
+    async fetchOrderBook(id: string | MarketOutcome): Promise<OrderBook> {
         await this.initPromise;
+        const resolvedId = resolveOutcomeId(id);
         try {
             const args: any[] = [];
-            args.push(id);
+            args.push(resolvedId);
             const response = await fetch(`${this.config.basePath}/api/${this.exchangeName}/fetchOrderBook`, {
                 method: 'POST',
                 headers: { 'Content-Type': 'application/json', ...this.getAuthHeaders() },
@@ -817,10 +827,11 @@ export abstract class Exchange {
      * ```
      */
     async fetchOHLCV(
-        outcomeId: string,
+        outcomeId: string | MarketOutcome,
         params: any
     ): Promise<PriceCandle[]> {
         await this.initPromise;
+        const resolvedOutcomeId = resolveOutcomeId(outcomeId);
         try {
             const paramsDict: any = { resolution: params.resolution };
             if (params.start) {
@@ -834,7 +845,7 @@ export abstract class Exchange {
             }
 
             const requestBody: FetchOHLCVRequest = {
-                args: [outcomeId, paramsDict],
+                args: [resolvedOutcomeId, paramsDict],
                 credentials: this.getCredentials()
             };
 
@@ -861,18 +872,19 @@ export abstract class Exchange {
      * @returns List of trades
      */
     async fetchTrades(
-        outcomeId: string,
+        outcomeId: string | MarketOutcome,
         params: any
     ): Promise<Trade[]> {
         await this.initPromise;
+        const resolvedOutcomeId = resolveOutcomeId(outcomeId);
         try {
             const paramsDict: any = { resolution: params.resolution };
             if (params.limit) {
                 paramsDict.limit = params.limit;
             }
 
             const requestBody: FetchTradesRequest = {
-                args: [outcomeId, paramsDict],
+                args: [resolvedOutcomeId, paramsDict],
                 credentials: this.getCredentials()
             };
 
@@ -911,10 +923,11 @@ export abstract class Exchange {
      * }
      * ```
      */
-    async watchOrderBook(outcomeId: string, limit?: number): Promise<OrderBook> {
+    async watchOrderBook(outcomeId: string | MarketOutcome, limit?: number): Promise<OrderBook> {
         await this.initPromise;
+        const resolvedOutcomeId = resolveOutcomeId(outcomeId);
         try {
-            const args: any[] = [outcomeId];
+            const args: any[] = [resolvedOutcomeId];
             if (limit !== undefined) {
                 args.push(limit);
             }
@@ -961,14 +974,15 @@ export abstract class Exchange {
      * ```
      */
     async watchTrades(
-        outcomeId: string,
+        outcomeId: string | MarketOutcome,
         address?: string,
         since?: number,
         limit?: number
     ): Promise<Trade[]> {
         await this.initPromise;
+        const resolvedOutcomeId = resolveOutcomeId(outcomeId);
         try {
-            const args: any[] = [outcomeId];
+            const args: any[] = [resolvedOutcomeId];
             if (address !== undefined) {
                 args.push(address);
             }