Cache results of Location.midnight & Location.noon

Do not force removal of suggested_display_precision from PeriodOfTimeSensor
entities because, 1) it's no longer needed, and 2) the core sensor logic
keeps changing it back to 2.

Author: pnbruckner

custom_components/sun2/helpers.py

@@ -108,7 +108,11 @@ def from_loc_params(cls, lp: LocParams) -> Self:
         tzi = dt_util.get_time_zone(tz := lp.time_zone)
         if not tzi:
             LOGGER.warning("Did not find time zone: %s", lp.time_zone)
-        return cls(Location(LocationInfo("", "", tz, lp.latitude, lp.longitude)), tzi)
+        loc = Location(LocationInfo("", "", tz, lp.latitude, lp.longitude))
+        # Cache results of methods used by many entity types.
+        loc.midnight = lru_cache(10)(loc.midnight)
+        loc.noon = lru_cache(10)(loc.noon)
+        return cls(loc, tzi)
 
 
 @lru_cache
@@ -555,8 +559,16 @@ def _astral_dt_2_dttm_none(
             fmt_result = self._dttm_2_str(result)
             if local:
                 result = nearest_second(result)
+            if hasattr(func, "cache_info"):
+                fmt_result += f" cache_info: {func.cache_info()}"
         LOGGER.debug(
-            "%s:   %-3s(%s)%35s-> %s", self._log_name, label, dt, "", fmt_result
+            "%s:   %-3s(%s, %5s)%28s-> %s",
+            self._log_name,
+            label,
+            dt,
+            local,
+            "",
+            fmt_result,
         )
         return result
 

custom_components/sun2/sensor.py

@@ -16,7 +16,6 @@
 from astral.sun import SUN_APPARENT_RADIUS
 
 from homeassistant.components.sensor import (
-    DOMAIN as SENSOR_DOMAIN,
     SensorDeviceClass,
     SensorEntity,
     SensorEntityDescription,
@@ -39,7 +38,6 @@
     EventStateChangedData,
     callback,
 )
-from homeassistant.helpers import entity_registry as er
 from homeassistant.helpers.event import (
     async_track_point_in_utc_time,
     async_track_state_change_event,
@@ -838,30 +836,6 @@ def extra_state_attributes(self) -> Mapping[str, Any] | None:
         )
         return data
 
-    async def async_added_to_hass(self) -> None:
-        """Run when entity about to be added to hass."""
-        await super().async_added_to_hass()
-
-        # In 3.1.0 and earlier, entity_description.suggested_display_precision was set
-        # to 3. Starting with HA 2024.2, that causes the state to be displayed as a
-        # float instead of HH:MM:SS. To fix that
-        # entity_description.suggested_display_precision is no longer being set.
-        # However, due to a bug in the sensor component, that value is not getting
-        # properly removed from the entity registry, causing the state to still be
-        # displayed as a float. To work around that bug, we'll forcibly remove it from
-        # the registry here if necessary.
-        ent_reg = er.async_get(self.hass)
-        sensor_options: Mapping[str, Any] = ent_reg.entities[
-            self.entity_id
-        ].options.get(SENSOR_DOMAIN, {})
-        if sensor_options.get("suggested_display_precision") is None:
-            return
-        sensor_options = dict(sensor_options)
-        del sensor_options["suggested_display_precision"]
-        ent_reg.async_update_entity_options(
-            self.entity_id, SENSOR_DOMAIN, sensor_options or None
-        )
-
     def _astral_event(self, dt: date) -> float | None:
         """Return astral event result."""
         if self._event == "daylight":