Add metadata data for Win builds

[ace-dent]

Add metadata .rc file for building Windows binaries, e.g.

1 VERSIONINFO
FILEVERSION     4,0,0,0
PRODUCTVERSION  4,0,0,0
FILEFLAGSMASK   0x3fL
FILEFLAGS       0x0L
FILEOS          0x40004L
FILETYPE        0x1L
FILESUBTYPE     0x0L
BEGIN
  BLOCK "StringFileInfo"
  BEGIN
    BLOCK "040904b0"
    BEGIN
      VALUE "CompanyName",     "Your Name"
      VALUE "FileDescription", "PNG integrity checker"
      VALUE "FileVersion",     "4.0.0"
      VALUE "InternalName",    "pngcheck"
      VALUE "OriginalFilename","pngcheck.exe"
      VALUE "ProductName",     "pngcheck"
      VALUE "ProductVersion",  "4.0.0"
      VALUE "BuildDate",       "2025-04-05"
    END
  END
  BLOCK "VarFileInfo"
  BEGIN
    VALUE "Translation", 0x0409, 1200
  END
END

and

i686-w64-mingw32-windres pngcheck.rc -O coff -o pngcheck.res
i686-w64-mingw32-gcc -Os -s pngcheck.c pngcheck.res -o pngcheck.exe

[svgeesus]

Probably a good idea, I will let someone familiar with Windows build environments comment on the specifics. @ctruta ?

[svgeesus]

@ctruta could you take a look?

[ctruta]

Looks legit to me. Although (@ace-dent, could you please not mind me for my comment):

From my point of view, this is neither thumbs-up nor thumbs-down. It's rather... elbows sideways... 🤷‍♂

I am typically in favour of bringing this kind of metadata into Windows GUI applications and Windows DLLs. But for Unix and Unix-ish command-line programs compiled in a Windows environment, this is much less of an issue. There are standard ways that are well-known by the users of these programs (most typically, options like -v and --version, or, in the case of pngcheck, simply typing the program name and seeing the help screen) that already fulfill this purpose. And they work as such, regardless of the underlying operating system.

In conclusion: my response is neither "yes" nor "no". It's "I don't have an opinion here, and regardless of what @svgeesus thinks about taking this in, I will agree".

[ctruta]

One more thing, with apologies for missing the details (and the pings) earlier:

If we do take this in, may I please ask for an update to the CMake file?

For Windows builds (and not only), we have the CMake file. The Makefile is just an extra, and it's for Unix builds only. The Makefile is as simple as it can be, and bringing back the old MinGW makefiles will just bring back a bunch of extra maintenance work. And not only that, but also a bunch of extra documentation (and extra confusion) about how to build the project on Windows.

So, @ace-dent, if you could please submit the necessary changes to the CMake file instead of the Makefile, that'd be great.

[ace-dent]

I'm not familiar enough with the project's build system (or Windows!) to undertake this work... at least currently...

Initially, can the project team agree what minimum level of metadata should be included? Also thinking how this might be rolled out across other pnggroup binaries...

Personally I just require a version number... although extra details might be nice...?

[ctruta]

I'm not familiar enough with the project's build system (or Windows!) to undertake this work... at least currently...

You are excused, @ace-dent 😃 CMake is quite a beast. I've been working with it ("professionally") for quite a few years, but for everything new, I cannot just go and do it. I need to check the docs, first... Although, admittedly, it's much easier nowadays: all I need to do is ask Gippity 🧐

Initially, can the project team agree what minimum level of metadata should be included? Also thinking how this might be rolled out across other pnggroup binaries...

Speaking for myself only, at least to clarify my previous point: I say "yes" to including metadata into the libpng DLL, and I say "not no" to including metadata into Windows-compiled programs that are Unix-like. And -- perhaps the most important part -- someone's gotta do it.

Personally I just require a version number... although extra details might be nice...?

Version number displayed in the help screen should be sufficient, no?

Here is what I customarily do, on Windows, on Linux, on MacOS, and on FreeBSD:

gcc --version | head -n1
clang --version | head -n1
tar --version | head -n1
gzip --version | head -n1
pngcheck -v | head -n1
optipng -v | head -n1
# etc.