Skip to content

Commit 822a464

Browse files
committed
Remove mxshieldv reference from 1.20.1 (1.4.9|20)
+ reset publish flag after failed attempt
1 parent 33a86cd commit 822a464

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!--publish=true-->
1+
<!--publish=false-->
22
### 1.4.9:
33
- Fix crash when used with [More Bed Variants](https://www.modrinth.com/mod/more-bed-variants) `2.1.0⁺`
44
- Fix recipe unlocking for _Stick Variant_ compatibility recipes for [Nemo's Campfires](https://www.modrinth.com/mod/nemos-campfires) and improve the ones for [More Grindstone Variants](https://www.modrinth.com/mod/more-grindstone-variants)

build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@ dependencies {
130130
modCompileOnly "maven.modrinth:more-fletching-tables:${project.mfletchingtablev_version_id}"
131131
// More Shield Variants
132132
modCompileOnly "maven.modrinth:more-shield-variants:${project.mshieldv_version_id}"
133-
// More Extra Shield Variants
134-
modCompileOnly "maven.modrinth:more-extra-shield-variants:${project.mxshieldv_version_id}"
135133
// More Bed Variants
136134
modCompileOnly "maven.modrinth:more-bed-variants:${project.mbedv_version_id}"
137135
// More Bookshelf Variants

src/main/java/de/pnku/mstv_base/trade/MstvVillagerTrades.java

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package de.pnku.mstv_base.trade;
22

3-
import de.pnku.shields_mxsv.item.MoreExtraShieldVariantItems;
43
import net.fabricmc.fabric.api.object.builder.v1.trade.TradeOfferHelper;
54
import net.fabricmc.loader.api.FabricLoader;
65
import net.minecraft.util.RandomSource;
@@ -49,7 +48,6 @@ public class MstvVillagerTrades {
4948
public static boolean isMFishingRodVLoaded = false;
5049
public static boolean isNemosCampfireVLoaded = false;
5150
public static boolean isMShieldVLoaded = false;
52-
public static boolean isMXShieldVLoaded = false;
5351
public static boolean isMBedVLoaded = false;
5452
public static boolean isMBookshelfVLoaded = false;
5553

@@ -66,7 +64,7 @@ public static void initMstvTradeRegistration() {
6664
if (isMFrameVLoaded) registerMframevTrades();
6765
if (isMFishingRodVLoaded) registerMfrodvTrades();
6866
if (isNemosCampfireVLoaded) registerNemocampfirevTrades();
69-
if (isMShieldVLoaded) registerMshieldvTrades(isMXShieldVLoaded);
67+
if (isMShieldVLoaded) registerMshieldvTrades();
7068
if (isMBedVLoaded) registerMbedvTrades();
7169
if (isMBookshelfVLoaded) registerMbookshelfvTrades();
7270
}
@@ -208,16 +206,11 @@ private static void registerNemocampfirevTrades(){
208206
replacedTrades.add(CAMPFIRE);
209207
}
210208

211-
private static void registerMshieldvTrades(boolean isMXShieldVLoaded){
209+
private static void registerMshieldvTrades(){
212210
// Armorer
213211
// Shield Sell
214-
if (!isMXShieldVLoaded){
215-
LOGGER.info("Registering mShieldV VillagerTrades");
216-
registerBiomeSpecificSellOffers(ARMORER, 3, 5, 1, 10, 12, highMod, false, new Item[]{ACACIA_SHIELD, OAK_SHIELD, DARK_OAK_SHIELD, JUNGLE_SHIELD, SHIELD});
217-
} else {
218-
LOGGER.info("Registering mXShieldV VillagerTrades");
219-
registerBiomeSpecificSellOffers(ARMORER, 3, 5, 1, 10, 12, highMod, false, new Item[]{MoreExtraShieldVariantItems.ACACIA_SHIELD, MoreExtraShieldVariantItems.OAK_SHIELD, MoreExtraShieldVariantItems.DARK_OAK_SHIELD, MoreExtraShieldVariantItems.JUNGLE_SHIELD, SHIELD});
220-
}
212+
LOGGER.info("Registering mShieldV VillagerTrades");
213+
registerBiomeSpecificSellOffers(ARMORER, 3, 5, 1, 10, 12, highMod, false, new Item[]{ACACIA_SHIELD, OAK_SHIELD, DARK_OAK_SHIELD, JUNGLE_SHIELD, SHIELD});
221214

222215
replacedTrades.add(SHIELD);
223216
}
@@ -354,7 +347,6 @@ private static void init(){
354347
isMFishingRodVLoaded = isLoaded("mstv-mfrv");
355348
isNemosCampfireVLoaded = isLoaded("nemos-campfires");
356349
isMShieldVLoaded = isLoaded("lolmsv");
357-
isMXShieldVLoaded = isLoaded("shields-mxsv");
358350
isMBedVLoaded = isLoaded("quad-lolmbdv");
359351
isMBookshelfVLoaded = isLoaded("lolmbv");
360352
}

0 commit comments

Comments
 (0)