Require ApplicationId in AppInsights client tests

Updated AppInsightsAuthTests to require ApplicationId in connection strings and adjusted test logic accordingly. Improved GraphImportTests to handle missing cognitive config by marking sentiment assertions inconclusive instead of failing.

Author: sambetts

src/AnalyticsEngine/Tests.UnitTests/AppInsightsAuthTests.cs

@@ -47,14 +47,14 @@ public void AppInsightsAPIClient_NullCredential_Throws()
         }
 
         /// <summary>
-        /// Verify AppInsightsAPIClient rejects a connection string without an InstrumentationKey.
+        /// Verify AppInsightsAPIClient rejects a connection string without an ApplicationId.
         /// </summary>
         [TestMethod]
         [ExpectedException(typeof(ArgumentException))]
-        public void AppInsightsAPIClient_ConnectionStringWithoutIKey_Throws()
+        public void AppInsightsAPIClient_ConnectionStringWithoutApplicationId_Throws()
         {
             var credential = new ClientSecretCredential("tenant-id", "client-id", "secret");
-            new AppInsightsAPIClient("IngestionEndpoint=https://test.in.applicationinsights.azure.com/", credential, AnalyticsLogger.ConsoleOnlyTracer());
+            new AppInsightsAPIClient("InstrumentationKey=00000000-0000-0000-0000-000000000001;IngestionEndpoint=https://test.in.applicationinsights.azure.com/", credential, AnalyticsLogger.ConsoleOnlyTracer());
         }
 
         /// <summary>
@@ -64,7 +64,7 @@ public void AppInsightsAPIClient_ConnectionStringWithoutIKey_Throws()
         public void AppInsightsAPIClient_ValidConnectionString_Constructs()
         {
             var credential = new ClientSecretCredential("tenant-id", "client-id", "secret");
-            var connStr = "InstrumentationKey=00000000-0000-0000-0000-000000000001;IngestionEndpoint=https://test.in.applicationinsights.azure.com/;LiveEndpoint=https://test.livediagnostics.monitor.azure.com/";
+            var connStr = "InstrumentationKey=00000000-0000-0000-0000-000000000001;IngestionEndpoint=https://test.in.applicationinsights.azure.com/;LiveEndpoint=https://test.livediagnostics.monitor.azure.com/;ApplicationId=00000000-0000-0000-0000-000000000002";
             using (var client = new AppInsightsAPIClient(connStr, credential, AnalyticsLogger.ConsoleOnlyTracer()))
             {
                 Assert.IsNotNull(client);

src/AnalyticsEngine/Tests.UnitTests/GraphImportTests.cs

@@ -342,7 +342,11 @@ public async Task SingleTeamSaveToSQLTest()
                 // Check last inserted log data
                 Assert.IsTrue(await db.TeamChannelStats.Where(l => l.Date == testDate).CountAsync() > 0, "Couldn't find any stats by test date");
                 var lastInserted = await db.TeamChannelStats.OrderByDescending(s => s.ID).FirstOrDefaultAsync();
-                Assert.IsTrue(lastInserted.SentimentScore.HasValue, "Last inserted log has no sentiment score");
+
+                if (settings.IsValidCognitiveConfig)
+                    Assert.IsTrue(lastInserted.SentimentScore.HasValue, "Last inserted log has no sentiment score");
+                else
+                    Assert.Inconclusive("No cognitive config provided, can't test sentiment score presence or value");
 
                 // Last inserted log should have msg count for messages on that day only
                 Assert.IsTrue(lastInserted.ChatsCount == channelWithMsgsOnDifferentDays.Messages
@@ -388,7 +392,12 @@ public async Task SingleTeamSaveToSQLTest()
                 // 4th count should only include the last happy msgs - 1 log as they're all on the same day
                 Assert.IsTrue(thirdPostTestChannelLogCount == 3, "Unexpected channel stats inserted for 2nd save of same data");
                 var lastInsertedHappy = await db.TeamChannelStats.OrderByDescending(s => s.ID).FirstOrDefaultAsync();
-                Assert.IsTrue(lastInsertedHappy.SentimentScore > lastInserted.SentimentScore, "Happier sentiment sentances aren't apparently more happy");
+
+
+                if (settings.IsValidCognitiveConfig)
+                    Assert.IsTrue(lastInsertedHappy.SentimentScore > lastInserted.SentimentScore, "Happier sentiment sentances aren't apparently more happy");
+                else
+                    Assert.Inconclusive("No cognitive config provided, can't test sentiment score presence or value");
             }
         }