August 2008 Point Release

Author: erwinvanhunen

Commands/Base/ConnectOnline.cs

@@ -1344,7 +1344,11 @@ private PnPConnection ConnectCredentials(PSCredential credentials)
                                                                      RequestTimeout,
                                                                      TenantAdminUrl,
                                                                      NoTelemetry,
+#if !ONPREMISES
                                                                      AzureEnvironment,
+#else
+                                                                     AzureEnvironment.Production,
+#endif
                                                                      SkipTenantAdminCheck,
                                                                      AuthenticationMode);
 #else

Commands/Base/PnPConnectionHelper.cs

@@ -563,7 +563,19 @@ internal static PnPConnection InstantiateWebloginConnection(Uri url, int minimal
 #endif
 
 #if !PNPPSCORE
-        internal static PnPConnection InstantiateSPOnlineConnection(Uri url, PSCredential credentials, PSHost host, bool currentCredentials, int minimalHealthScore, int retryCount, int retryWait, int requestTimeout, string tenantAdminUrl, bool disableTelemetry, AzureEnvironment azureEnvironment, bool skipAdminCheck = false, ClientAuthenticationMode authenticationMode = ClientAuthenticationMode.Default)
+        internal static PnPConnection InstantiateSPOnlineConnection(Uri url, 
+            PSCredential credentials, 
+            PSHost host, 
+            bool currentCredentials, 
+            int minimalHealthScore, 
+            int retryCount, 
+            int retryWait, 
+            int requestTimeout, 
+            string tenantAdminUrl, 
+            bool disableTelemetry,
+            AzureEnvironment azureEnvironment, 
+            bool skipAdminCheck = false, 
+            ClientAuthenticationMode authenticationMode = ClientAuthenticationMode.Default)
         {
             var context = new PnPClientContext(url.AbsoluteUri);
 
@@ -676,12 +688,12 @@ internal static PnPConnection InstantiateSPOnlineConnection(Uri url, PSCredentia
             var connectionType = ConnectionType.OnPrem;
 #else
             var connectionType = ConnectionType.O365;
-#endif
+
             if (url.Host.ToLowerInvariant().EndsWith($"sharepoint.{OfficeDevPnP.Core.AuthenticationManager.GetSharePointDomainSuffix(azureEnvironment)}"))
             {
                 connectionType = ConnectionType.O365;
             }
-
+#endif
             if (skipAdminCheck == false)
             {
                 if (IsTenantAdminSite(context))
@@ -744,7 +756,7 @@ internal static PnPConnection InstantiateSPOnlineConnection(Uri url, PSCredentia
 #endif
 
 #if !PNPPSCORE
-        internal static PnPConnection InstantiateAdfsConnection(Uri url, bool useKerberos, PSCredential credentials, PSHost host, int minimalHealthScore, int retryCount, int retryWait, int requestTimeout, string tenantAdminUrl, bool disableTelemetry, bool skipAdminCheck = false, string loginProviderName = null)
+            internal static PnPConnection InstantiateAdfsConnection(Uri url, bool useKerberos, PSCredential credentials, PSHost host, int minimalHealthScore, int retryCount, int retryWait, int requestTimeout, string tenantAdminUrl, bool disableTelemetry, bool skipAdminCheck = false, string loginProviderName = null)
         {
             using (var authManager = new OfficeDevPnP.Core.AuthenticationManager())
             {

Commands/Properties/AssemblyInfo.cs

@@ -51,8 +51,8 @@
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
 #if !PNPPSCORE
-[assembly: AssemblyVersion("3.25.2009.0")]
-[assembly: AssemblyFileVersion("3.25.2009.0")]
+[assembly: AssemblyVersion("3.24.2008.1")]
+[assembly: AssemblyFileVersion("3.24.2008.1")]
 #else
 [assembly: AssemblyVersion("4.0.0.0")]
 [assembly: AssemblyFileVersion("4.0.0.0")]

Commands/Search/GetSearchCrawlLog.cs

@@ -115,14 +115,22 @@ protected override void ExecuteCmdlet()
                 string postFilter = string.Empty;
                 if (string.IsNullOrWhiteSpace(Filter) && ContentSource == ContentSource.Sites)
                 {
+#if !ONPREMISES
                     Filter = $"https://{GetHostName()}.sharepoint.{OfficeDevPnP.Core.AuthenticationManager.GetSharePointDomainSuffix(PnPConnection.CurrentConnection.AzureEnvironment)}";
+#else
+                    Filter = $"https://{GetHostName()}.sharepoint.com";
+#endif
                 }
 
                 int origLimit = RowLimit;
                 if (ContentSource == ContentSource.UserProfiles)
                 {
                     postFilter = Filter;
+#if !ONPREMISES
                     Filter = $"https://{GetHostName()}-my.sharepoint.{OfficeDevPnP.Core.AuthenticationManager.GetSharePointDomainSuffix(PnPConnection.CurrentConnection.AzureEnvironment)}";
+#else
+                    Filter = $"https://{GetHostName()}-my.sharepoint.com";
+#endif
                     RowLimit = MaxRows;
                 }
 
@@ -175,7 +183,7 @@ protected override void ExecuteCmdlet()
             }
         }
 
-        #region Helper functions
+#region Helper functions
 
         private string GetHostName()
         {
@@ -241,6 +249,6 @@ private object ConvertToPSObject(IDictionary<string, object> r)
             }
             return res;
         }
-        #endregion
+#endregion
     }
 }

version.txt

@@ -1 +1 @@
-3.25.2009.0
+3.24.2008.1