Merge pull request #1079 from koskila/fix/1078

Fix #1078 by improving error handling

Author: gautamdsheth

src/lib/PnP.Framework/Extensions/ClientContextExtensions.cs

@@ -578,7 +578,6 @@ public static ClientContext GetSiteCollectionContext(this ClientRuntimeContext c
         /// <returns>True if app-only, false otherwise</returns>
         public static bool IsAppOnly(this ClientRuntimeContext clientContext)
         {
-
             // Set initial result to false
             var result = false;
 
@@ -692,7 +691,18 @@ public static string GetAccessToken(this ClientRuntimeContext clientContext)
                     };
                     // Issue a dummy request to get it from the Authorization header
                     clientContext.ExecutingWebRequest += handler;
-                    clientContext.ExecuteQuery();
+                    try
+                    {
+                        clientContext.ExecuteQuery();
+                    }
+                    catch (Exception ex)
+                    {
+                        // This can fail for whatever reason, but if we already have the AccessToken, it doesn't matter
+                        if (String.IsNullOrEmpty(accessToken))
+                        {
+                            throw new AggregateException("Fetching the AccessToken to inspect whether the ClientContext is AppOnly or not failed. There might be more information in the InnerExceptions.", ex);
+                        }
+                    }
                     clientContext.ExecutingWebRequest -= handler;
                 }
             }