Merge pull request #1173 from vascoazevedo08/dev-pnp

Rever commit 26bf318 and refactor Safely apply footer DisplayName in Provision Site Footer

Author: gautamdsheth

src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectSiteFooterSettings.cs

@@ -46,13 +46,7 @@ public override ProvisioningTemplate ExtractObjects(Web web, ProvisioningTemplat
                     var chrome = pnpCoreContext.Web.GetBrandingManager().GetChromeOptions();
 
                     footer.Enabled = chrome.Footer.Enabled;
-                    // Avoid setting a null DisplayName, which causes errors if the footer was previously enabled.
-                    // This can happen when a user disables the footer after it was set.
-                    // Only update if DisplayName is present in the template.
-                    if (template.Footer.DisplayName != null)
-                    {
-                        chrome.Footer.DisplayName = template.Footer.DisplayName;
-                    }
+                    footer.DisplayName = chrome.Footer.DisplayName;
                     footer.Layout = (PnP.Framework.Provisioning.Model.SiteFooterLayout)Enum.Parse(typeof(PnP.Framework.Provisioning.Model.SiteFooterLayout), chrome.Footer.Layout.ToString());
                     footer.BackgroundEmphasis = (PnP.Framework.Provisioning.Model.Emphasis)Enum.Parse(typeof(PnP.Framework.Provisioning.Model.Emphasis), chrome.Footer.Emphasis.ToString());
                 }
@@ -375,7 +369,13 @@ public override TokenParser ProvisionObjects(Web web, ProvisioningTemplate templ
                         var chrome = pnpCoreContext.Web.GetBrandingManager().GetChromeOptions();
 
                         chrome.Footer.Enabled = web.FooterEnabled;
-                        chrome.Footer.DisplayName = template.Footer.DisplayName;
+                        // Avoid setting a null DisplayName, which causes errors if the footer was previously enabled.
+                        // This can happen when a user disables the footer after it was set.
+                        // Only update if DisplayName is present in the template.
+                        if (template.Footer?.DisplayName != null)
+                        {
+                            chrome.Footer.DisplayName = template.Footer.DisplayName;
+                        }
                         chrome.Footer.Layout = (PnP.Core.Model.SharePoint.FooterLayoutType)Enum.Parse(typeof(PnP.Core.Model.SharePoint.FooterLayoutType), template.Footer.Layout.ToString());
                         chrome.Footer.Emphasis = (PnP.Core.Model.SharePoint.FooterVariantThemeType)Enum.Parse(typeof(PnP.Core.Model.SharePoint.FooterVariantThemeType), template.Footer.BackgroundEmphasis.ToString());