Skip to content

Commit ba09446

Browse files
authored
Merge pull request #1216 from roberAlb/patch-1
Ensure List Fields Are Included When Site Column Titles Differ
2 parents 18aa2ad + f6f7b4e commit ba09446

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectListInstance.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2739,13 +2739,13 @@ private ListInstance ExtractFields(Web web, List siteList, List<FieldRef> conten
27392739
var siteContext = web.Context.GetSiteCollectionContext();
27402740
var rootWeb = siteContext.Site.RootWeb;
27412741
siteColumns = rootWeb.Fields;
2742-
siteContext.Load(siteColumns, scs => scs.Include(sc => sc.Id, sc => sc.DefaultValue, sc => sc.PinnedToFiltersPane, sc => sc.ShowInFiltersPane, sc => sc.CustomFormatter, sc => sc.AutofillInfo));
2742+
siteContext.Load(siteColumns, scs => scs.Include(sc => sc.Id, sc => sc.DefaultValue, sc => sc.PinnedToFiltersPane, sc => sc.ShowInFiltersPane, sc => sc.CustomFormatter, sc => sc.AutofillInfo, sc => sc.Title));
27432743
siteContext.ExecuteQueryRetry();
27442744
}
27452745
else
27462746
{
27472747
siteColumns = web.Fields;
2748-
web.Context.Load(siteColumns, scs => scs.Include(sc => sc.Id, sc => sc.DefaultValue, sc => sc.PinnedToFiltersPane, sc => sc.ShowInFiltersPane, sc => sc.CustomFormatter, sc => sc.AutofillInfo));
2748+
web.Context.Load(siteColumns, scs => scs.Include(sc => sc.Id, sc => sc.DefaultValue, sc => sc.PinnedToFiltersPane, sc => sc.ShowInFiltersPane, sc => sc.CustomFormatter, sc => sc.AutofillInfo, sc => sc.Title));
27492749
web.Context.ExecuteQueryRetry();
27502750
}
27512751

@@ -2760,6 +2760,7 @@ private ListInstance ExtractFields(Web web, List siteList, List<FieldRef> conten
27602760
{
27612761
//include the list field if settings on List field instance are different then the ones on the web field
27622762
if (siteColumn.PinnedToFiltersPane != field.PinnedToFiltersPane
2763+
|| siteColumn.Title != field.Title
27632764
|| siteColumn.AutofillInfo != field.AutofillInfo
27642765
|| siteColumn.ShowInFiltersPane != field.ShowInFiltersPane
27652766
|| string.IsNullOrWhiteSpace(siteColumn.CustomFormatter) != string.IsNullOrWhiteSpace(field.CustomFormatter)

0 commit comments

Comments
 (0)