getFolderByServerRelativePath seems to have issues with # in foldernames

[chr-sad]

Major Version

4.x

Minor Version Number

4.12.0

Target environment

All

Additional environment details

I'm using NodeJS v22.14.0

Expected or Desired Behavior

When I use the IWeb getFolderByServerRelativePath API I want to be able to use folder names including special characters like % and #. Currently when the folder name contains # in pnp v 4.12.0 the request is not handled correctly and resolves in 404 not found error because of truncated URLs.

Observed Behavior

When I call the API with parentFolderServerRelativeUrl='/sites/xxx/UploadDocumentLibraryLarge/test/xxx/test # test':

      const test = await webRef.getFolderByServerRelativePath(parentFolderServerRelativeUrl);
      const testItem = await test.getItem();

The request in the network tab is truncated before the #

Steps to Reproduce

Here is a snippet of the Sample-Code:

  try {
    if (parentFolderServerRelativeUrl) {
      const test = await webRef.getFolderByServerRelativePath(parentFolderServerRelativeUrl);
      const testItem = await test.getItem();
      if (testItem) {
        console.log('testItem', testItem);
      }
    }
  }
  catch (err) { ... }

When the folder has # as a special character, the test.getItem() method results in an error.

[juliemturner]

Based on the source code for version 4.12.0 the function getFolderByServerRelativePath does not encode the URI component of the url you're passing it, deliberately.

See folderFromServerRelativePath and then the related encodePathNoURIEncode

I'll discuss this case with the team to verify there's not a better solution, but the solution I found for you is to encode the # in the parentFolderServerRelativeUrl as %23 and then it works fine.

[chr-sad]

@juliemturner thank you for the again very fast reply - the support here is truly exceptional!

You are right, that would be my solution as well - I just thought I would open a ticket as well because in the documentation of the API (https://github.com/pnp/pnpjs/blob/6e8c92a5430f6936ee9444e81f47012ed05917b0/packages/sp/folders/web.ts) I found an info specially for # and % so I thought it was maybe a bug.

[juliemturner]

Yeah, I want to talk to the others on the team before saying more, just wanted to make sure you were unblocked, but yes... good 👀

[chr-sad]

perfect - thank you! :)