Fixed issue with trying to write a verbose message outside of the main cmdlet thread.

Author: erwinvanhunen

src/Commands/Base/ConnectOnline.cs

@@ -601,7 +601,7 @@ private PnPConnection ConnectDeviceLogin()
                         }
                         else
                         {
-                            WriteVerbose("Using Managed AppId from secure store");
+                            messageWriter.WriteVerbose("Using Managed AppId from secure store");
                         }
                     }
 

src/Commands/Utilities/CmdletMessageWriter.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Management.Automation;
+using System.Security.Cryptography.Pkcs;
 using System.Threading;
 
 namespace PnP.PowerShell.Commands.Utilities
@@ -38,7 +39,25 @@ public void Start()
                     }
                     else
                     {
-                        Cmdlet.Host.UI.WriteLine(message.Text);
+                        switch (message.Type)
+                        {
+                            case MessageType.Message:
+                                {
+                                    Cmdlet.Host.UI.WriteLine(message.Text);
+                                    break;
+                                }
+                            case MessageType.Warning:
+                                {
+                                    Cmdlet.Host.UI.WriteWarningLine(message.Text);
+                                    break;
+                                }
+                            case MessageType.Verbose:
+                                {
+                                    Cmdlet.Host.UI.WriteVerboseLine(message.Text);
+                                    break;
+                                }
+                        }
+
                     }
                     break;
                 }
@@ -63,6 +82,14 @@ public void WriteMessage(string message, bool formatted = true)
             }
         }
 
+        public void WriteVerbose(string message)
+        {
+            lock (LockToken)
+            {
+                Queue.Enqueue(new Message() { Formatted = false, Text = message, Type = MessageType.Verbose });
+            }
+        }
+
         internal class Message
         {
             public string Text { get; set; }
@@ -73,7 +100,8 @@ internal class Message
         internal enum MessageType
         {
             Message,
-            Warning
+            Warning,
+            Verbose
         }
 
         private static List<string> WordWrap(string text, int maxLineLength)
@@ -99,7 +127,7 @@ internal static void WriteFormattedWarning(PSCmdlet cmdlet, string message)
         {
             WriteFormattedMessage(cmdlet, new Message { Text = message, Type = MessageType.Warning, Formatted = true });
         }
-        
+
         internal static void WriteFormattedMessage(PSCmdlet cmdlet, Message message)
         {
             if (cmdlet.Host.Name == "ConsoleHost" && cmdlet.Host.UI.RawUI.MaxWindowSize.Width > 8)
@@ -142,6 +170,11 @@ internal static void WriteFormattedMessage(PSCmdlet cmdlet, Message message)
                             cmdlet.WriteWarning($"{notificationColor}\n{outMessage}{resetColor}\n");
                             break;
                         }
+                    case MessageType.Verbose:
+                        {
+                            cmdlet.WriteVerbose(outMessage);
+                            break;
+                        }
                 }
             }
             else
@@ -158,6 +191,11 @@ internal static void WriteFormattedMessage(PSCmdlet cmdlet, Message message)
                             cmdlet.WriteWarning(message.Text);
                             break;
                         }
+                    case MessageType.Verbose:
+                        {
+                            cmdlet.WriteVerbose(message.Text);
+                            break;
+                        }
                 }
             }
         }