Enhance IsCopilotSearchable parameter handling for non-ImageDocumentLibrary types (#5181)

Author: gautamdsheth

documentation/Add-PnPOrgAssetsLibrary.md

@@ -103,15 +103,17 @@ Accept wildcard characters: False
 ```
 
 ### -IsCopilotSearchable
-Indicates that the organizational assets library should be searchable in the CoPilot search experience in Office applications to locate corporate images. Only works when the OrgAssetType is set to ImageDocumentLibrary.
+Indicates that the organizational assets library should be searchable in the Copilot search experience in Office applications to locate corporate images.
+
+This setting is only supported when `-OrgAssetType` is set to `ImageDocumentLibrary`. When using other `OrgAssetType` values (for example `OfficeTemplateLibrary`), this setting will always be `False` and specifying `-IsCopilotSearchable:$true` will result in an error.
 
 ```yaml
 Type: Boolean
 Parameter Sets: (All)
 
 Required: False
 Position: Named
-Default value: True
+Default value: False
 Accept pipeline input: False
 Accept wildcard characters: False
 ```

src/Commands/Admin/AddOrgAssetsLibrary.cs

@@ -26,11 +26,35 @@ public class AddOrgAssetsLibrary : PnPSharePointOnlineAdminCmdlet
         public bool DefaultOriginAdded = true;
 
         [Parameter(Mandatory = false)]
-        public bool IsCopilotSearchable = true;
+        public bool IsCopilotSearchable = false;
 
         protected override void ExecuteCmdlet()
         {
-            Tenant.AddToOrgAssetsLibWithConfig(CdnType, LibraryUrl, ThumbnailUrl, OrgAssetType, DefaultOriginAdded, new OrgAssetsLibraryConfigParam { IsCopilotSearchable = IsCopilotSearchable});
+            var config = new OrgAssetsLibraryConfigParam();
+
+            // Copilot search is only supported for ImageDocumentLibrary.
+            // SharePoint has started enforcing this more strictly, so we guard against sending an invalid config.
+            if (OrgAssetType != OrgAssetType.ImageDocumentLibrary)
+            {
+                if (ParameterSpecified(nameof(IsCopilotSearchable)) && IsCopilotSearchable)
+                {
+                    ThrowTerminatingError(new ErrorRecord(
+                        new PSArgumentException("-IsCopilotSearchable can only be set to $true when -OrgAssetType is ImageDocumentLibrary."),
+                        "IsCopilotSearchableUnsupportedForOrgAssetType",
+                        ErrorCategory.InvalidArgument,
+                        IsCopilotSearchable));
+                }
+
+                config.IsCopilotSearchable = false;
+                config.IsCopilotSearchablePresent = false;
+            }
+            else
+            {
+                config.IsCopilotSearchable = IsCopilotSearchable;
+                config.IsCopilotSearchablePresent = ParameterSpecified(nameof(IsCopilotSearchable));
+            }
+
+            Tenant.AddToOrgAssetsLibWithConfig(CdnType, LibraryUrl, ThumbnailUrl, OrgAssetType, DefaultOriginAdded, config);
             AdminContext.ExecuteQueryRetry();
         }
     }