Skip to content

Commit 7feff0e

Browse files
committed
Add removal of starting and ending quotes to enable completers to work on partially quoted strings
1 parent 8c45a82 commit 7feff0e

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

src/Commands/Base/Completers/ContentTypeCompleter.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,12 @@ public sealed class ContentTypeCompleter : IArgumentCompleter
1313
{
1414
public IEnumerable<CompletionResult> CompleteArgument(string commandName, string parameterName, string wordToComplete, CommandAst commandAst, IDictionary fakeBoundParameters)
1515
{
16+
wordToComplete = wordToComplete.Trim('"');
17+
1618
IEnumerable<ContentType> result = PnPConnection.Current.Context.LoadQuery(PnPConnection.Current.Context.Web.AvailableContentTypes.Include(f => f.Name));
1719
PnPConnection.Current.Context.ExecuteQueryRetry();
1820
foreach (var ct in result.Where(l => l.Name.StartsWith(wordToComplete, StringComparison.InvariantCultureIgnoreCase)))
19-
{
21+
{
2022
yield return new CompletionResult($"\"{ct.Name}\"");
2123
}
2224
}

src/Commands/Base/Completers/FieldInternalNameCompleter.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ public sealed class FieldInternalNameCompleter : IArgumentCompleter
1313
{
1414
public IEnumerable<CompletionResult> CompleteArgument(string commandName, string parameterName, string wordToComplete, CommandAst commandAst, IDictionary fakeBoundParameters)
1515
{
16+
wordToComplete = wordToComplete.Trim('"');
17+
1618
IEnumerable<Field> result = PnPConnection.Current.Context.LoadQuery(PnPConnection.Current.Context.Web.AvailableFields.Include(f => f.InternalName));
1719
PnPConnection.Current.Context.ExecuteQueryRetry();
1820
foreach (var field in result.Where(l => l.InternalName.StartsWith(wordToComplete, StringComparison.InvariantCultureIgnoreCase)))

src/Commands/Base/Completers/ListNameCompleter.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ public sealed class ListNameCompleter : IArgumentCompleter
1212
{
1313
public IEnumerable<CompletionResult> CompleteArgument(string commandName, string parameterName, string wordToComplete, CommandAst commandAst, IDictionary fakeBoundParameters)
1414
{
15+
wordToComplete = wordToComplete.Trim('"');
16+
1517
IEnumerable<List> result = PnPConnection.Current.Context.LoadQuery(PnPConnection.Current.Context.Web.Lists.Include(list => list.Title));
1618
PnPConnection.Current.Context.ExecuteQueryRetry();
1719
foreach (var list in result.Where(l => l.Title.StartsWith(wordToComplete, StringComparison.InvariantCultureIgnoreCase)))

0 commit comments

Comments
 (0)