Fixed verbose message on DeviceLogin

Author: erwinvanhunen

src/Commands/Base/ConnectOnline.cs

@@ -165,7 +165,7 @@ public class ConnectOnline : BasePSCmdlet
         [Parameter(Mandatory = true, ParameterSetName = ParameterSet_APPONLYAADTHUMBPRINT)]
         [Parameter(Mandatory = true, ParameterSetName = ParameterSet_APPONLYAADCERTIFICATE)]
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_INTERACTIVE)]
-        [Parameter(Mandatory = true, ParameterSetName = ParameterSet_DEVICELOGIN)]
+        [Parameter(Mandatory = false, ParameterSetName = ParameterSet_DEVICELOGIN)]
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_ENVIRONMENTVARIABLE)]
         [Parameter(Mandatory = false, ParameterSetName = ParameterSet_OSLOGIN)]
         public string Tenant;
@@ -530,7 +530,7 @@ private PnPConnection ConnectSpoManagement()
         /// </summary>
         /// <returns>PnPConnection based on the parameters provided in the parameter set</returns>
         private PnPConnection ConnectDeviceLogin()
-        {
+        { 
             WriteVerbose("Connecting using Device Login");
 
             var messageWriter = new CmdletMessageWriter(this);

src/Commands/Base/PnPConnection.cs

@@ -298,7 +298,7 @@ internal static PnPConnection CreateWithDeviceLogin(string clientId, string url,
                     if (msalServiceException.Message.StartsWith("AADSTS50059:"))
                     {
                         cancellationTokenSource.Cancel();
-                        throw new Exception("Please specify -Tenant with either the tenant id or hostname.");
+                        throw new Exception("Default authentication request failed. Please specify the -Tenant parameter with either the tenant id or hostname to authenticate.");
                     }
                     else
                     {

src/Commands/Utilities/CmdletMessageWriter.cs

@@ -70,6 +70,7 @@ public void WriteWarning(string message, bool formatted = true)
         {
             lock (LockToken)
             {
+
                 Queue.Enqueue(new Message() { Formatted = formatted, Text = message, Type = MessageType.Warning });
             }
         }
@@ -84,9 +85,12 @@ public void WriteMessage(string message, bool formatted = true)
 
         public void WriteVerbose(string message)
         {
-            lock (LockToken)
+            if (Cmdlet.MyInvocation.BoundParameters.ContainsKey("Verbose"))
             {
-                Queue.Enqueue(new Message() { Formatted = false, Text = message, Type = MessageType.Verbose });
+                lock (LockToken)
+                {
+                    Queue.Enqueue(new Message() { Formatted = false, Text = message, Type = MessageType.Verbose });
+                }
             }
         }