Skip to content

Commit 631da79

Browse files
committed
pnpjs v2
1 parent dfa8f1e commit 631da79

File tree

5 files changed

+54
-41
lines changed

5 files changed

+54
-41
lines changed

package-lock.json

Lines changed: 33 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,7 @@
2626
"@microsoft/sp-lodash-subset": "1.11.0",
2727
"@microsoft/sp-office-ui-fabric-core": "1.11.0",
2828
"@microsoft/sp-webpart-base": "1.11.0",
29-
"@pnp/common": "1.0.1",
30-
"@pnp/logging": "1.0.1",
31-
"@pnp/odata": "1.0.1",
32-
"@pnp/sp": "1.0.1",
29+
"@pnp/sp": "2.0.6",
3330
"@pnp/telemetry-js": "2.0.0",
3431
"chart.js": "2.7.3",
3532
"color": "^3.1.2",

src/common/utilities/SPHelper.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,18 @@ import * as Constants from '../Constants';
55
import { ListItemAccessor } from '@microsoft/sp-listview-extensibility';
66
import { SPField } from '@microsoft/sp-page-context';
77
import { sp } from '@pnp/sp';
8+
import '@pnp/sp/fields';
89
import { SPHttpClient } from '@microsoft/sp-http';
10+
import { IFieldInfo } from '@pnp/sp/fields';
11+
import '@pnp/sp/site-users/web';
912

1013
declare var window: any;
1114

15+
interface IFieldLookupInfo extends IFieldInfo {
16+
LookupWebId: string;
17+
LookupList: string;
18+
}
19+
1220
/**
1321
* Helper class to work with SharePoint objects and entities
1422
*/
@@ -231,7 +239,7 @@ export class SPHelper {
231239
sp.setup({
232240
spfxContext: context
233241
});
234-
sp.web.lists.getByTitle(context.pageContext.list.title).fields.getById(fieldId).select('LookupWebId', 'LookupList').get().then(f => {
242+
sp.web.lists.getByTitle(context.pageContext.list.title).fields.getById(fieldId).select('LookupWebId', 'LookupList').get().then((f: IFieldLookupInfo) => {
235243
sp.site.openWebById(f.LookupWebId).then(openedWeb => {
236244
openedWeb.web.select('Url').get().then(w => {
237245
field.LookupDisplayUrl = `${w.Url}/_layouts/15/listform.aspx?PageType=4&ListId=${f.LookupList}`;
@@ -389,4 +397,4 @@ export class SPHelper {
389397

390398
return null;
391399
}
392-
}
400+
}

src/services/FolderExplorerService.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@ import { ServiceKey, ServiceScope } from "@microsoft/sp-core-library";
22
import { PageContext } from "@microsoft/sp-page-context";
33
import { IFolderExplorerService } from "./IFolderExplorerService";
44
import { IFolder } from "./IFolderExplorerService";
5-
import { sp, Web, List, FolderAddResult } from "@pnp/sp";
5+
import { sp } from "@pnp/sp";
6+
import "@pnp/sp/webs";
7+
import { Web } from "@pnp/sp/webs";
8+
import "@pnp/sp/folders";
9+
import { IFolderAddResult } from "@pnp/sp/folders";
610

711
export class FolderExplorerService implements IFolderExplorerService {
812

@@ -36,7 +40,7 @@ export class FolderExplorerService implements IFolderExplorerService {
3640
private _getDocumentLibraries = async (webAbsoluteUrl: string): Promise<IFolder[]> => {
3741
let results: IFolder[] = [];
3842
try {
39-
const web = new Web(webAbsoluteUrl);
43+
const web = Web(webAbsoluteUrl);
4044
const libraries: any[] = await web.lists.filter('BaseTemplate eq 101 and Hidden eq false').expand('RootFolder').select('Title', 'RootFolder/ServerRelativeUrl').orderBy('Title').get();
4145

4246
results = libraries.map((library): IFolder => {
@@ -66,7 +70,7 @@ export class FolderExplorerService implements IFolderExplorerService {
6670
private _getFolders = async (webAbsoluteUrl: string, folderRelativeUrl: string): Promise<IFolder[]> => {
6771
let results: IFolder[] = [];
6872
try {
69-
const web = new Web(webAbsoluteUrl);
73+
const web = Web(webAbsoluteUrl);
7074
let foldersResult: IFolder[] = await web.getFolderByServerRelativeUrl(folderRelativeUrl).folders.select('Name', 'ServerRelativeUrl').orderBy('Name').get();
7175
results = foldersResult.filter(f => f.Name != "Forms");
7276
} catch (error) {
@@ -94,8 +98,8 @@ export class FolderExplorerService implements IFolderExplorerService {
9498
private _addFolder = async (webAbsoluteUrl: string, folderRelativeUrl: string, name: string): Promise<IFolder> => {
9599
let folder: IFolder = null;
96100
try {
97-
const web = new Web(webAbsoluteUrl);
98-
let folderAddResult: FolderAddResult = await web.getFolderByServerRelativeUrl(folderRelativeUrl).folders.add(name);
101+
const web = Web(webAbsoluteUrl);
102+
let folderAddResult: IFolderAddResult = await web.getFolderByServerRelativeUrl(folderRelativeUrl).folders.add(name);
99103
if (folderAddResult && folderAddResult.data) {
100104
folder = {
101105
Name: folderAddResult.data.Name,

src/services/SPService.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { ISPLists } from "../common/SPEntities";
33
import { WebPartContext } from "@microsoft/sp-webpart-base";
44
import { ExtensionContext } from "@microsoft/sp-extension-base";
55
import { SPHttpClient, SPHttpClientResponse, ISPHttpClientOptions } from "@microsoft/sp-http";
6-
import { sp, Web } from '@pnp/sp';
76

87
export default class SPService implements ISPService {
98

@@ -50,7 +49,7 @@ export default class SPService implements ISPService {
5049
public async getListItems(filterText: string, listId: string, internalColumnName: string, keyInternalColumnName?: string, webUrl?: string, filter?: string, substringSearch: boolean = false ): Promise<any[]> {
5150
let returnItems: any[];
5251
const filterStr = substringSearch ? // JJ - 20200613 - find by substring as an option
53-
`substringof('${encodeURIComponent(filterText.replace("'","''"))}',${internalColumnName})${filter ? ' and ' + filter : ''}`
52+
`substringof('${encodeURIComponent(filterText.replace("'","''"))}',${internalColumnName})${filter ? ' and ' + filter : ''}`
5453
: `startswith(${internalColumnName},'${encodeURIComponent(filterText.replace("'","''"))}')${filter ? ' and ' + filter : ''}`; //string = filterList ? `and ${filterList}` : '';
5554
try {
5655
const webAbsoluteUrl = !webUrl ? this._context.pageContext.web.absoluteUrl : webUrl;

0 commit comments

Comments
 (0)