Skip to content

Commit 632c446

Browse files
committed
Enhancement for #113
1 parent ce0c972 commit 632c446

File tree

5 files changed

+35
-26
lines changed

5 files changed

+35
-26
lines changed

CHANGELOG.JSON

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@
88
"`PeoplePicker`: ability to specify the source site to load users from [#110](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/110)",
99
"`WebPartTitle`: changing font-sizes on different resolutions [#114](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/114)",
1010
"`WebPartTitle`: Added accessibility tags for web part title [#121](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/121)",
11-
"`ListView`: Resizable columns - introduced a `isResizable` property [#119](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/119)"
11+
"`ListView`: Resizable columns - introduced a `isResizable` property [#119](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/119)",
12+
"`TaxonomyPicker`: table markup changed to DIV [#113](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/113)"
1213
],
1314
"fixes": [
14-
"`IFrameDialog`: dialog width is not correct in IE11 [#118](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/118)"
15+
"`IFrameDialog`: dialog width is not correct in IE11 [#118](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/118)",
16+
"`PeoplePicker`: fix freezes when typing in search values [#117](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/117)"
1517
]
1618
},
1719
"contributions": ["Thomas Lamb", "Joel Rodrigues", "Mikael Svenson"]

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@
88
- `WebPartTitle`: changing font-sizes on different resolutions [#114](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/114)
99
- `WebPartTitle`: Added accessibility tags for web part title [#121](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/121)
1010
- `ListView`: Resizable columns - introduced a `isResizable` property [#119](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/119)
11+
- `TaxonomyPicker`: table markup changed to DIV [#113](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/113)
1112

1213
**Fixes**
1314

1415
- `IFrameDialog`: dialog width is not correct in IE11 [#118](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/118)
16+
- `PeoplePicker`: fix freezes when typing in search values [#117](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/117)
1517

1618
## 1.7.0
1719

docs/documentation/docs/about/release-notes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@
88
- `WebPartTitle`: changing font-sizes on different resolutions [#114](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/114)
99
- `WebPartTitle`: Added accessibility tags for web part title [#121](https://github.com/SharePoint/sp-dev-fx-controls-react/pull/121)
1010
- `ListView`: Resizable columns - introduced a `isResizable` property [#119](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/119)
11+
- `TaxonomyPicker`: table markup changed to DIV [#113](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/113)
1112

1213
**Fixes**
1314

1415
- `IFrameDialog`: dialog width is not correct in IE11 [#118](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/118)
16+
- `PeoplePicker`: fix freezes when typing in search values [#117](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/117)
1517

1618
## 1.7.0
1719

src/controls/taxonomyPicker/TaxonomyPicker.module.scss

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,19 @@
1414
}
1515
}
1616

17-
.termFieldTable {
17+
.termField {
18+
align-items: center;
1819
border-spacing: 0;
20+
display: flex;
1921
width: 100%;
2022

21-
.termFieldRow {
22-
vertical-align: initial;
23+
.termFieldInput {
24+
width: 90%;
25+
}
26+
27+
.termFieldButton {
28+
text-align: center;
29+
width: 10%;
2330
}
2431

2532
input[type="text"] {

src/controls/taxonomyPicker/TaxonomyPicker.tsx

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -249,27 +249,23 @@ export class TaxonomyPicker extends React.Component<ITaxonomyPickerProps, ITaxon
249249
return (
250250
<div>
251251
{this.props.label && <Label>{this.props.label}</Label>}
252-
<table className={styles.termFieldTable}>
253-
<tbody>
254-
<tr>
255-
<td>
256-
<TermPicker
257-
context={this.props.context}
258-
termPickerHostProps={this.props}
259-
disabled={this.props.disabled}
260-
value={this.state.activeNodes}
261-
isTermSetSelectable={this.props.isTermSetSelectable}
262-
onChanged={this.termsFromPickerChanged}
263-
allowMultipleSelections={this.props.allowMultipleSelections}
264-
disabledTermIds={this.props.disabledTermIds}
265-
disableChildrenOfDisabledParents={this.props.disableChildrenOfDisabledParents} />
266-
</td>
267-
<td className={styles.termFieldRow}>
268-
<IconButton disabled={this.props.disabled} iconProps={{ iconName: 'Tag' }} onClick={this.onOpenPanel} />
269-
</td>
270-
</tr>
271-
</tbody>
272-
</table>
252+
<div className={styles.termField}>
253+
<div className={styles.termFieldInput}>
254+
<TermPicker
255+
context={this.props.context}
256+
termPickerHostProps={this.props}
257+
disabled={this.props.disabled}
258+
value={this.state.activeNodes}
259+
isTermSetSelectable={this.props.isTermSetSelectable}
260+
onChanged={this.termsFromPickerChanged}
261+
allowMultipleSelections={this.props.allowMultipleSelections}
262+
disabledTermIds={this.props.disabledTermIds}
263+
disableChildrenOfDisabledParents={this.props.disableChildrenOfDisabledParents} />
264+
</div>
265+
<div className={styles.termFieldButton}>
266+
<IconButton disabled={this.props.disabled} iconProps={{ iconName: 'Tag' }} onClick={this.onOpenPanel} />
267+
</div>
268+
</div>
273269

274270
<FieldErrorMessage errorMessage={this.state.errorMessage} />
275271

0 commit comments

Comments
 (0)