Merge pull request #48 from SharePoint/dev

Fix for sorting listview items

Author: estruyf

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Releases
 
+## 1.2.2
+
+**Fixes**
+
+- Fixes an issue sorting in the `ListView` control while items were selected. Indexes were not updated.
+
 ## 1.2.1
 
 **Fixes**

docs/documentation/docs/about/release-notes.md

@@ -1,5 +1,11 @@
 # Releases
 
+## 1.2.2
+
+**Fixes**
+
+- Fixes an issue sorting in the `ListView` control while items were selected. Indexes were not updated.
+
 ## 1.2.1
 
 **Fixes**

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@pnp/spfx-controls-react",
   "description": "Reusable React controls for SharePoint Framework solutions",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "engines": {
     "node": ">=0.10.0"
   },

src/controls/listView/ListView.tsx

@@ -345,15 +345,30 @@ export class ListView extends React.Component<IListViewProps, IListViewState> {
    * @param descending
    */
   private _sortItems(items: any[], columnName: string, descending = false): any[] {
+    // Sort the items
     const ascItems = sortBy(items, [columnName]);
-    return descending ? ascItems.reverse() : ascItems;
+    const sortedItems = descending ? ascItems.reverse() : ascItems;
+
+    // Check if selection needs to be updated
+    const selection = this._selection.getSelection();
+    if (selection && selection.length > 0) {
+      // Clear selection
+      this._selection.setItems([], true);
+      setTimeout(() => {
+        // Find new index
+        let idxs: number[] = selection.map(item => findIndex(sortedItems, item));
+        idxs.forEach(idx => this._selection.setIndexSelected(idx, true, false));
+      }, 0);
+    }
+
+    // Return the sorted items list
+    return sortedItems;
   }
 
   /**
    * Default React component render method
    */
   public render(): React.ReactElement<IListViewProps> {
-
     return (
       <div>
         <DetailsList