Skip to content

Commit 7cc8061

Browse files
committed
Merge branch 'feature/listview-styles' of https://github.com/MonalisaBaltatescu/sp-dev-fx-controls-react into MonalisaBaltatescu-feature/listview-styles
2 parents a32a00b + 11f948b commit 7cc8061

File tree

5 files changed

+39
-30
lines changed

5 files changed

+39
-30
lines changed

.circleci/config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ workflows:
129129
only:
130130
- dev
131131
- v2
132+
ignore:
133+
- v2-dev
132134
- build_next:
133135
requires:
134136
- build

src/controls/listView/IListView.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ export interface IListViewProps {
6868
* Set to false by default
6969
*/
7070
stickyHeader?: boolean;
71+
/**
72+
* Class name to apply additional styles on list view wrapper
73+
*/
74+
className?: string;
7175
/**
7276
* Custom sorting function.
7377
* @returns sorted collection of items

src/controls/listView/ListView.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ const classNames = mergeStyleSets({
3030
/**
3131
* Wrap the listview in a scrollable pane if sticky header = true
3232
*/
33-
const ListViewWrapper = ({ stickyHeader, children }) => (stickyHeader ?
34-
<div className={classNames.wrapper} >
35-
<ScrollablePane scrollbarVisibility={ScrollbarVisibility.auto}>
36-
{children}
37-
</ScrollablePane>
38-
</div>
39-
: children
40-
);
33+
const ListViewWrapper = ({ stickyHeader, children, className }) => (stickyHeader ?
34+
<div className={`${classNames.wrapper} ${className ?? ""}`} >
35+
<ScrollablePane scrollbarVisibility={ScrollbarVisibility.auto}>
36+
{children}
37+
</ScrollablePane>
38+
</div>
39+
: children
40+
);
4141

4242
/**
4343
* Lock the searchbox when scrolling if sticky header = true
@@ -595,7 +595,7 @@ export class ListView extends React.Component<IListViewProps, IListViewState> {
595595
}
596596

597597
return (
598-
<ListViewWrapper stickyHeader={!!this.props.stickyHeader}>
598+
<ListViewWrapper stickyHeader={!!this.props.stickyHeader} className={this.props.className}>
599599
<DragDropFiles enable={dragDropFiles}
600600
iconName="BulkUpload"
601601
labelMessage={strings.UploadFileHeader}

src/webparts/controlsTest/components/ControlsTest.module.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,10 @@ $themePrimary: '[theme:themePrimary, default:#0078d7]';
8282
.carouselImageContent {
8383
height: 400px;
8484
}
85+
86+
.listViewWrapper {
87+
height: 200px;
88+
}
8589
}
8690

8791
.dialogContainer {

src/webparts/controlsTest/components/ControlsTest.tsx

Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
438438
canMoveNext: true,
439439
currentCarouselElement: this.carouselElements[0],
440440
comboBoxListItemPickerListId: '0ffa51d7-4ad1-4f04-8cfe-98209905d6da',
441-
comboBoxListItemPickerIds: [{Id: 1, Title: '111'}],
441+
comboBoxListItemPickerIds: [{ Id: 1, Title: '111' }],
442442
treeViewSelectedKeys: ['gc1', 'gc3'],
443443
showAnimatedDialog: false,
444444
showCustomisedAnimatedDialog: false,
@@ -1290,21 +1290,20 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
12901290
</DragDropFiles>
12911291
<br></br>
12921292

1293-
1294-
<ListView items={this.state.items}
1295-
viewFields={viewFields}
1296-
iconFieldName='ServerRelativeUrl'
1297-
groupByFields={groupByFields}
1298-
compact={true}
1299-
selectionMode={SelectionMode.single}
1300-
selection={this._getSelection}
1301-
showFilter={true}
1302-
dragDropFiles={true}
1303-
onDrop={this._getDropFiles}
1304-
stickyHeader={true}
1305-
// defaultFilter="Team"
1306-
/>
1307-
1293+
<ListView items={this.state.items}
1294+
viewFields={viewFields}
1295+
iconFieldName='ServerRelativeUrl'
1296+
groupByFields={groupByFields}
1297+
compact={true}
1298+
selectionMode={SelectionMode.single}
1299+
selection={this._getSelection}
1300+
showFilter={true}
1301+
dragDropFiles={true}
1302+
onDrop={this._getDropFiles}
1303+
stickyHeader={true}
1304+
className={styles.listViewWrapper}
1305+
// defaultFilter="Team"
1306+
/>
13081307

13091308
<ChartControl type={ChartType.Bar}
13101309
data={{
@@ -1393,7 +1392,7 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
13931392

13941393

13951394
<div className="ms-font-m">Site picker tester:
1396-
<SitePicker
1395+
<SitePicker
13971396
context={this.props.context}
13981397
label={'select sites'}
13991398
mode={'site'}
@@ -1459,7 +1458,7 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
14591458
}} />
14601459
<PrimaryButton text="Change default items" onClick={() => {
14611460
this.setState({
1462-
comboBoxListItemPickerIds: [{Id: 2, Title: '222'}]
1461+
comboBoxListItemPickerIds: [{ Id: 2, Title: '222' }]
14631462
});
14641463
}} />
14651464

@@ -1770,7 +1769,7 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
17701769
>
17711770
<NorthstarText size="large" weight="semibold">
17721771
Content #1
1773-
</NorthstarText>
1772+
</NorthstarText>
17741773
</Flex>
17751774
),
17761775
},
@@ -1785,7 +1784,7 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
17851784
>
17861785
<NorthstarText size="large" weight="semibold">
17871786
Content #2
1788-
</NorthstarText>
1787+
</NorthstarText>
17891788
</Flex>
17901789
),
17911790
},
@@ -1800,7 +1799,7 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
18001799
>
18011800
<NorthstarText size="large" weight="semibold">
18021801
Content #3
1803-
</NorthstarText>
1802+
</NorthstarText>
18041803
</Flex>
18051804
),
18061805
},

0 commit comments

Comments
 (0)