Skip to content

Commit 9a1966b

Browse files
committed
Merge branch 'dev' of github.com:SharePoint/sp-dev-fx-controls-react into dev
2 parents c0d3726 + b88a9f2 commit 9a1966b

File tree

5 files changed

+21
-7
lines changed

5 files changed

+21
-7
lines changed

CHANGELOG.JSON

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,21 @@
3030
"`TaxonomyPicker`: Suggestion/match does not work as expected [#604](https://github.com/pnp/sp-dev-fx-controls-react/issues/604)",
3131
"`TaxonomyPicker`: Include check for separator while filtering path of terms when anchorId is configured [#625](https://github.com/pnp/sp-dev-fx-controls-react/issues/625)",
3232
"`FilePicker`: Bing API search issue [#633](https://github.com/pnp/sp-dev-fx-controls-react/pull/633)",
33-
"`ListView`: Sort fires selection [#621](https://github.com/pnp/sp-dev-fx-controls-react/issues/621)"
33+
"`ListView`: Sort fires selection [#621](https://github.com/pnp/sp-dev-fx-controls-react/issues/621)",
34+
"`Map`: A minor issue in componentWillUpdate method to get the next props rather than the current props.[#641](https://github.com/pnp/sp-dev-fx-controls-react/pull/641)",
35+
"`IFrameDialog`: dialog size is incorrect when opening the dialog second time [#615](https://github.com/pnp/sp-dev-fx-controls-react/issues/615)",
36+
"`FolderPicker`: imports don't work [#614](https://github.com/pnp/sp-dev-fx-controls-react/issues/614)"
3437
]
3538
},
3639
"contributions": [
40+
"[Alexey Sadomov](https://github.com/sadomovalex)",
41+
"[Anoop Tatti](https://github.com/anoopt)",
3742
"[Devang Bhavsar](https://github.com/devangbhavsar89)",
43+
"[Gautam Sheth](https://github.com/gautamdsheth)",
3844
"[geltapatio](https://github.com/geltapatio)",
3945
"[Joel Jeffery](https://github.com/joeljeffery)",
40-
"[Victor Pollet](https://github.com/TheThor59)",
41-
"[Alexey Sadomov](https://github.com/sadomovalex)",
42-
"[Gautam Sheth](https://github.com/gautamdsheth)",
43-
"[Piotr Siatka](https://github.com/siata13)"
46+
"[Piotr Siatka](https://github.com/siata13)",
47+
"[Victor Pollet](https://github.com/TheThor59)"
4448
]
4549
},
4650
{

docs/documentation/docs/controls/FolderPicker.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ Here is an example of the control:
2525
- Import the control into your component:
2626

2727
```TypeScript
28-
import { FolderPicker, IFolder } from "@pnp/spfx-controls-react/lib/FolderPicker";
28+
import FolderPicker from "@pnp/spfx-controls-react/lib/controls/folderPicker/FolderPicker";
29+
import { IFolder } from "@pnp/spfx-controls-react/lib/FolderPicker";
2930
```
3031

3132
- Use the `FolderPicker` control in your code as follows:

src/controls/folderPicker/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
export * from './FolderPicker';
22
export * from './IFolderPickerProps';
33
export * from './IFolderPickerState';
4+
export { IFolder } from '../../services/IFolderExplorerService';

src/controls/iFrameDialog/IFrameDialog.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,14 @@ export class IFrameDialog extends React.Component<IFrameDialogProps, IFrameDialo
9494
this.setDialogStyling();
9595
}
9696

97+
public componentWillReceiveProps(nextProps: IFrameDialogProps) {
98+
if (nextProps.hidden && nextProps.hidden !== this.props.hidden) {
99+
this.setState({
100+
isStylingSet: false
101+
});
102+
}
103+
}
104+
97105
public componentDidUpdate(prevProps: IFrameDialogProps, prevState: IFrameDialogState): void {
98106
this.setDialogStyling();
99107
}

src/controls/map/Map.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export class Map extends React.Component<IMapProps, IMapState> {
4848
public componentWillUpdate(nextProps: IMapProps, nextState: IMapState): void {
4949
if (!isEqual(this.props.coordinates, nextProps.coordinates)) {
5050
this.setState({
51-
coordinates: this.props.coordinates
51+
coordinates: nextProps.coordinates
5252
});
5353
}
5454
}

0 commit comments

Comments
 (0)