Skip to content

Commit 9ad640d

Browse files
authored
Merge pull request #1907 from pnp/spfx-1-20
SPFx 1.20 support
2 parents 2bd431c + dc9083b commit 9ad640d

File tree

27 files changed

+4367
-5542
lines changed

27 files changed

+4367
-5542
lines changed

.eslintrc.js

Lines changed: 2 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -27,39 +27,6 @@ module.exports = {
2727
'@rushstack/security/no-unsafe-regexp': 0,
2828
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
2929
'@typescript-eslint/adjacent-overload-signatures': 1,
30-
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
31-
//
32-
// CONFIGURATION: By default, these are banned: String, Boolean, Number, Object, Symbol
33-
'@typescript-eslint/ban-types': [
34-
1,
35-
{
36-
'extendDefaults': false,
37-
'types': {
38-
'String': {
39-
'message': 'Use \'string\' instead',
40-
'fixWith': 'string'
41-
},
42-
'Boolean': {
43-
'message': 'Use \'boolean\' instead',
44-
'fixWith': 'boolean'
45-
},
46-
'Number': {
47-
'message': 'Use \'number\' instead',
48-
'fixWith': 'number'
49-
},
50-
'Object': {
51-
'message': 'Use \'object\' instead, or else define a proper TypeScript type:'
52-
},
53-
'Symbol': {
54-
'message': 'Use \'symbol\' instead',
55-
'fixWith': 'symbol'
56-
},
57-
'Function': {
58-
'message': 'The \'Function\' type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with \'new\'.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape.'
59-
}
60-
}
61-
}
62-
],
6330
// RATIONALE: Code is more readable when the type of every variable is immediately obvious.
6431
// Even if the compiler may be able to infer a type, this inference will be unavailable
6532
// to a person who is reviewing a GitHub diff. This rule makes writing code harder,
@@ -125,7 +92,7 @@ module.exports = {
12592
//
12693
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
12794
// Set to 1 (warning) or 2 (error) to enable the rule
128-
'@typescript-eslint/no-parameter-properties': 0,
95+
'@typescript-eslint/parameter-properties': 0,
12996
// RATIONALE: When left in shipping code, unused variables often indicate a mistake. Dead code
13097
// may impact performance.
13198
//
@@ -358,4 +325,4 @@ module.exports = {
358325
}
359326
}
360327
]
361-
};
328+
};

.yo-rc.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"@microsoft/generator-sharepoint": {
3-
"version": "1.19.0",
3+
"version": "1.20.0",
44
"libraryName": "sp-dev-fx-controls-react",
55
"libraryId": "92b1e52c-a5fa-490a-bcf4-76080f39442c",
66
"environment": "spo",
@@ -11,7 +11,7 @@
1111
"nodeVersion": "18.17.1",
1212
"sdksVersions": {
1313
"@microsoft/microsoft-graph-client": "3.0.2",
14-
"@microsoft/teams-js": "2.12.0"
14+
"@microsoft/teams-js": "2.24.0"
1515
},
1616
"componentType": "extension",
1717
"extensionType": "ApplicationCustomizer"

0 commit comments

Comments
 (0)