Skip to content

Commit a4835d5

Browse files
author
Piotr Siatka
committed
Update comments.
1 parent 1714976 commit a4835d5

File tree

8 files changed

+30
-93
lines changed

8 files changed

+30
-93
lines changed

src/controls/filePicker/LinkFilePickerTab/LinkFilePickerTab.tsx

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
import * as React from 'react';
22

3-
// Custom styles
4-
import styles from './LinkFilePickerTab.module.scss';
5-
6-
// Custom props and state
73
import { ILinkFilePickerTabProps, ILinkFilePickerTabState } from '.';
8-
9-
// Office Fabric
4+
import { GeneralHelper } from '../../../Utilities';
5+
import { IFilePickerResult } from '../FilePicker.types';
106
import { PrimaryButton, DefaultButton } from 'office-ui-fabric-react/lib/components/Button';
117
import { TextField } from 'office-ui-fabric-react/lib/TextField';
128

13-
// Localized strings
149
import * as strings from 'ControlStrings';
15-
import { GeneralHelper } from '../../../Utilities';
16-
import { IFilePickerResult } from '../FilePicker.types';
10+
import styles from './LinkFilePickerTab.module.scss';
11+
1712

1813
export default class LinkFilePickerTab extends React.Component<ILinkFilePickerTabProps, ILinkFilePickerTabState> {
1914
constructor(props: ILinkFilePickerTabProps) {

src/controls/filePicker/OneDriveFilesTab/OneDriveFilesTab.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,14 @@ import { IOneDriveFilesTabProps, IOneDriveFilesTabState } from '.';
33
import { IFile } from '../../../services/FileBrowserService.types';
44
import { OneDriveFilesBreadcrumbItem } from './OneDriveFilesTab.types';
55
import { findIndex } from '@microsoft/sp-lodash-subset';
6-
7-
86
import { Breadcrumb, IBreadcrumbItem } from 'office-ui-fabric-react/lib/Breadcrumb';
97
import { FileBrowser } from '../controls';
108
import { PrimaryButton, DefaultButton } from 'office-ui-fabric-react/lib/Button';
9+
import { Link } from 'office-ui-fabric-react/lib/Link';
10+
import { IFilePickerResult } from '../FilePicker.types';
1111

1212
import styles from './OneDriveFilesTab.module.scss';
1313
import * as strings from 'ControlStrings';
14-
import { mergeStyles } from 'office-ui-fabric-react/lib/Styling';
15-
import { css } from 'office-ui-fabric-react/lib/Utilities';
16-
import { Link } from 'office-ui-fabric-react/lib/Link';
17-
import { IFilePickerResult } from '../FilePicker.types';
1814

1915
export class OneDriveFilesTab extends React.Component<IOneDriveFilesTabProps, IOneDriveFilesTabState> {
2016
constructor(props: IOneDriveFilesTabProps) {

src/controls/filePicker/RecentFilesTab/RecentFilesTab.tsx

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import * as React from 'react';
22

3-
// Custom styles
4-
import styles from './RecentFilesTab.module.scss';
5-
6-
// Office Fabric
73
import { PrimaryButton, DefaultButton } from 'office-ui-fabric-react/lib/components/Button';
84
import { Spinner } from 'office-ui-fabric-react/lib/Spinner';
95
import { FocusZone } from 'office-ui-fabric-react/lib/FocusZone';
@@ -13,18 +9,14 @@ import { css } from "@uifabric/utilities/lib/css";
139
import { Selection, SelectionMode, SelectionZone } from 'office-ui-fabric-react/lib/Selection';
1410
import { Image, ImageFit } from 'office-ui-fabric-react/lib/Image';
1511
import { Check } from 'office-ui-fabric-react/lib/Check';
16-
17-
// Custom props and states
18-
import { IRecentFilesTabProps, IRecentFilesTabState } from '.';
19-
20-
// Localized resources
21-
import * as strings from 'ControlStrings';
22-
23-
// PnP
2412
import { Placeholder } from '../../../Placeholder';
2513
import { IRecentFile } from '../../../services/FilesSearchService.types';
2614
import { IFilePickerResult } from '../FilePicker.types';
2715
import { GeneralHelper } from '../../../Utilities';
16+
import { IRecentFilesTabProps, IRecentFilesTabState } from '.';
17+
18+
import * as strings from 'ControlStrings';
19+
import styles from './RecentFilesTab.module.scss';
2820

2921
/**
3022
* Rows per page

src/controls/filePicker/SiteFilePickerTab/SiteFilePickerTab.tsx

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,16 @@
11
import * as React from 'react';
22
import { findIndex } from '@microsoft/sp-lodash-subset';
3-
4-
// Custom styles
5-
import styles from './SiteFilePickerTab.module.scss';
6-
7-
// Custom picker interface
83
import { ISiteFilePickerTabProps, ISiteFilePickerTabState } from '.';
94
import { DocumentLibraryBrowser, FileBrowser } from '../controls';
10-
11-
// Office Fabric
125
import { PrimaryButton, DefaultButton } from 'office-ui-fabric-react/lib/components/Button';
136
import { Breadcrumb, IBreadcrumbItem } from 'office-ui-fabric-react/lib/Breadcrumb';
14-
15-
// Localized strings
16-
import * as strings from 'ControlStrings';
177
import { IFile, ILibrary } from '../../../services/FileBrowserService.types';
188
import { Link } from 'office-ui-fabric-react/lib/Link';
199
import { IFilePickerResult, FilePickerBreadcrumbItem } from '../FilePicker.types';
2010

11+
import styles from './SiteFilePickerTab.module.scss';
12+
import * as strings from 'ControlStrings';
13+
2114
export default class SiteFilePickerTab extends React.Component<ISiteFilePickerTabProps, ISiteFilePickerTabState> {
2215
constructor(props: ISiteFilePickerTabProps) {
2316
super(props);

src/controls/filePicker/UploadFilePickerTab/UploadFilePickerTab.tsx

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,14 @@
11
import * as React from 'react';
22

3-
// Makes thingy pretty
4-
import styles from './UploadFilePickerTab.module.scss';
5-
6-
// Needed for our custom pane tab
73
import { IUploadFilePickerTabProps, IUploadFilePickerTabState } from '.';
8-
9-
// Office Fabric to the rescue!
4+
import { IFilePickerResult } from '../FilePicker.types';
5+
import { GeneralHelper } from '../../../common/utilities';
106
import { PrimaryButton, DefaultButton } from 'office-ui-fabric-react/lib/components/Button';
117

12-
// Localization
138
import * as strings from 'ControlStrings';
14-
import { IFilePickerResult } from '../FilePicker.types';
15-
import { GeneralHelper } from '../../../common/utilities';
9+
import styles from './UploadFilePickerTab.module.scss';
10+
11+
1612

1713
export default class UploadFilePickerTab extends React.Component<IUploadFilePickerTabProps, IUploadFilePickerTabState> {
1814
constructor(props: IUploadFilePickerTabProps) {

src/controls/filePicker/WebSearchTab/WebSearchTab.tsx

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
import * as React from 'react';
22

3-
// Good looks
4-
import styles from './WebSearchTab.module.scss';
5-
6-
// Localization
7-
import * as strings from 'ControlStrings';
8-
9-
// Types
103
import { IWebSearchTabProps, IWebSearchTabState, ISearchSuggestion, ImageSize, ImageAspect, ImageLicense, DEFAULT_SUGGESTIONS, MAX_ROW_HEIGHT, ROWS_PER_PAGE } from '.';
11-
12-
// Offce Fabric stuff
134
import { PrimaryButton, DefaultButton } from 'office-ui-fabric-react/lib/components/Button';
145
import { Label } from 'office-ui-fabric-react/lib/Label';
156
import { SearchBox } from 'office-ui-fabric-react/lib/SearchBox';
@@ -22,16 +13,14 @@ import { List } from 'office-ui-fabric-react/lib/List';
2213
import { IRectangle } from 'office-ui-fabric-react/lib/Utilities';
2314
import { Selection, SelectionMode, SelectionZone } from 'office-ui-fabric-react/lib/Selection';
2415
import { MessageBar } from 'office-ui-fabric-react/lib/MessageBar';
25-
26-
// Used for HTTP requests
27-
import { SPHttpClient, IHttpClientOptions, SPHttpClientResponse } from '@microsoft/sp-http';
28-
29-
// CSS utility to combine classes dynamically
3016
import { css } from '@uifabric/utilities/lib/css';
3117
import { IFilePickerResult } from '../FilePicker.types';
3218
import { GeneralHelper } from '../../../common/utilities';
3319
import { ISearchResult, BingQuerySearchParams } from '../../../services/FilesSearchService.types';
3420

21+
import styles from './WebSearchTab.module.scss';
22+
import * as strings from 'ControlStrings';
23+
3524
/**
3625
* Renders search suggestions and performs seach queries
3726
*/
@@ -62,7 +51,7 @@ export default class WebSearchTab extends React.Component<IWebSearchTabProps, IW
6251
*/
6352
public render(): React.ReactElement<IWebSearchTabProps> {
6453
const { query, results } = this.state;
65-
const { bingSearchService } = this.props;
54+
6655
return (
6756
<div className={styles.tabContainer}>
6857
<div className={styles.tabHeaderContainer}>

src/controls/filePicker/controls/DocumentTile/DocumentTile.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import * as strings from 'ControlStrings';
66
import { Check } from 'office-ui-fabric-react/lib/Check';
77
import { ScreenWidthMinLarge } from 'office-ui-fabric-react/lib/Styling';
88
import { IDocumentTileProps } from './IDocumentTileProps';
9-
import { IFile } from '../../../../services/FileBrowserService.types';
109

1110
const MAX_ASPECT_RATIO = 3;
1211

src/controls/filePicker/controls/FileBrowser/FileBrowser.tsx

Lines changed: 8 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,21 @@
11
import * as React from 'react';
2-
3-
// Custom styles
4-
import styles from './FileBrowser.module.scss';
5-
6-
// Custom properties and state
2+
import { IFile, FilesQueryResult } from '../../../../services/FileBrowserService.types';
3+
import { GeneralHelper } from '../../../../Utilities';
4+
import { LoadingState } from './IFileBrowserState';
5+
import { TilesList } from '../TilesList/TilesList';
6+
import { IFilePickerResult } from '../../FilePicker.types';
77
import { IFileBrowserProps, IFileBrowserState, ViewType } from '.';
8-
9-
// Office Fabric
108
import { Spinner } from 'office-ui-fabric-react/lib/Spinner';
11-
import {
12-
DetailsList,
13-
DetailsListLayoutMode,
14-
Selection,
15-
SelectionMode,
16-
IColumn,
17-
IDetailsRowProps,
18-
DetailsRow,
19-
SelectionZone
20-
} from 'office-ui-fabric-react/lib/DetailsList';
9+
import { DetailsList, DetailsListLayoutMode, Selection, SelectionMode, IColumn, IDetailsRowProps, DetailsRow, SelectionZone } from 'office-ui-fabric-react/lib/DetailsList';
2110
import { CommandBar, ICommandBarItemProps } from 'office-ui-fabric-react/lib/CommandBar';
2211
import { IContextualMenuItem } from 'office-ui-fabric-react/lib/ContextualMenu';
2312
import { ScrollablePane } from 'office-ui-fabric-react/lib/ScrollablePane';
2413

25-
const LAYOUT_STORAGE_KEY: string = 'comparerSiteFilesLayout';
26-
27-
// Localized strings
14+
import styles from './FileBrowser.module.scss';
2815
import * as strings from 'ControlStrings';
2916

30-
import { IFile, FilesQueryResult } from '../../../../services/FileBrowserService.types';
31-
import { GeneralHelper } from '../../../../Utilities';
32-
import { LoadingState } from './IFileBrowserState';
33-
import { TilesList } from '../TilesList/TilesList';
34-
import { IFilePickerResult } from '../../FilePicker.types';
35-
import { FocusZone } from 'office-ui-fabric-react/lib/FocusZone';
17+
const LAYOUT_STORAGE_KEY: string = 'comparerSiteFilesLayout';
3618

37-
/**
38-
* Renders list of file in a list.
39-
* I should have used the PnP ListView control, but I wanted specific behaviour that I didn't
40-
* get with the PnP control.
41-
*/
4219
export class FileBrowser extends React.Component<IFileBrowserProps, IFileBrowserState> {
4320
private _selection: Selection;
4421
constructor(props: IFileBrowserProps) {

0 commit comments

Comments
 (0)