Skip to content

Commit af9e87d

Browse files
author
Alex Terentiev
committed
Merge branch 'russgove-master' into dev
2 parents 92f9791 + 2faaae5 commit af9e87d

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

src/controls/listItemPicker/ComboBoxListItemPicker.tsx

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export class ComboBoxListItemPicker extends React.Component<IComboBoxListItemPic
5252
//query += filter;
5353
let keyColumnName = keyColumnInternalName || "Id";
5454

55-
if (!this._options || listId !== this.props.listId) {
55+
if (!this._options || listId !== this.props.listId|| filter !== this.props.filter) {
5656
const listItems = await this._listItemRepo.getListItemsByFilterClause(query,
5757
listId,
5858
columnInternalName,
@@ -61,12 +61,12 @@ export class ComboBoxListItemPicker extends React.Component<IComboBoxListItemPic
6161
itemLimit || 100,
6262
orderBy);
6363

64-
this._options = listItems.map(option => {
65-
return {
66-
key: option[keyColumnName],
67-
text: option[columnInternalName || "Id"]
68-
};
69-
});
64+
this._options = listItems.map(option => {
65+
return {
66+
key: option[keyColumnName],
67+
text: option[columnInternalName || "Id"]
68+
};
69+
});
7070
}
7171

7272
const selectedItems = this._getSelectedItems(props);
@@ -87,6 +87,10 @@ export class ComboBoxListItemPicker extends React.Component<IComboBoxListItemPic
8787
});
8888
await this.loadOptions(nextProps, false);
8989
}
90+
if (nextProps.filter !== this.props.filter) {
91+
92+
await this.loadOptions(nextProps, false);
93+
}
9094
if (!isEqual(nextProps.defaultSelectedItems, this.props.defaultSelectedItems)) {
9195
const selectedItems = this._getSelectedItems(nextProps);
9296
this.setState({

0 commit comments

Comments
 (0)