remove warnings

Author: joelfmrodrigues

src/controls/viewPicker/IViewPicker.ts

@@ -1,5 +1,4 @@
 import { BaseComponentContext } from '@microsoft/sp-component-base';
-import { ISPView } from '../../../src/common/SPEntities';
 import { IDropdownOption } from 'office-ui-fabric-react/lib/Dropdown';
 
 
@@ -93,4 +92,4 @@ export interface IViewPickerState {
   * Keys of the currently selected item(s).
   */
   selectedView?: string | string[];
-}
+}

src/controls/viewPicker/ViewPicker.tsx

@@ -2,13 +2,11 @@ import * as React from 'react';
 import cloneDeep from 'lodash/cloneDeep';
 import { Dropdown, IDropdownOption, IDropdownProps } from 'office-ui-fabric-react/lib/Dropdown';
 import { Async } from 'office-ui-fabric-react/lib/Utilities';
-import { Label } from 'office-ui-fabric-react/lib/Label';
-import { Spinner, SpinnerSize } from 'office-ui-fabric-react/lib/Spinner';
 import * as telemetry from '../../common/telemetry';
 import { ISPService } from '../../services/ISPService';
 import { SPServiceFactory } from '../../services/SPServiceFactory';
 import { IViewPickerProps, IViewPickerState } from './IViewPicker';
-import { ISPView, ISPViews } from "../../common/SPEntities";
+import { ISPView } from "../../common/SPEntities";
 import styles from './ViewPicker.module.scss';
 
 // Empty view value
@@ -30,30 +28,30 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
         this.async = new Async(this);
     }
 
-    public componentDidMount(): void {
+    public async componentDidMount(): Promise<void> {
         // Start retrieving the list views
-        this.loadViews();
+        await this.loadViews();
     }
 
   /**
    * componentDidUpdate lifecycle hook
    * @param prevProps
    * @param prevState
    */
-    public componentDidUpdate(prevProps: IViewPickerProps, _prevState: IViewPickerState): void {
+    public async componentDidUpdate(prevProps: IViewPickerProps, _prevState: IViewPickerState): Promise<void> {
         if (
-            this.props.listId !== prevProps.listId || 
+            this.props.listId !== prevProps.listId ||
             this.props.webAbsoluteUrl !== prevProps.webAbsoluteUrl ||
-            this.props.orderBy !== prevProps.orderBy 
+            this.props.orderBy !== prevProps.orderBy
             ) {
-          this.loadViews();
+          await this.loadViews();
         }
 
         if(prevProps.selectedView !== this.props.selectedView){
           this.setSelectedViews();
         }
     }
-    
+
     /**
      * Called when the component will unmount
     */
@@ -67,9 +65,9 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
 
 
         const viewsToExclude: string[] = this.props.viewsToExclude || [];
-        let options: IDropdownOption[] = [];
+        const options: IDropdownOption[] = [];
         const service: ISPService = SPServiceFactory.createService(this.props.context, true, 5000, this.props.webAbsoluteUrl);
-        let results = await service.getViews(
+        const results = await service.getViews(
           this.props.listId,
           this.props.orderBy,
           this.props.filter
@@ -108,14 +106,14 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
         this.setState({
           results: options
         });
-        
+
     }
 
     /**
      * Set the currently selected views(s);
      */
     private setSelectedViews(): void {
-      let _selectedView = cloneDeep(this.props.selectedView);
+      const _selectedView = cloneDeep(this.props.selectedView);
 
       this.setState({
         selectedView:_selectedView
@@ -155,7 +153,7 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
     }
   }
 
-   
+
 
     /**
      * Renders the ViewPicker controls with Office UI Fabric
@@ -179,7 +177,7 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
             placeholder,
             onChange: this.onChange,
           };
-        
+
         if(multiSelect){
           dropdownProps.multiSelect = true;
           dropdownProps.selectedKeys = selectedView as string [];
@@ -194,4 +192,4 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
         );
     }
 
-}
+}

src/services/ISPService.ts

@@ -1,4 +1,4 @@
-import { ISPContentType, ISPField, ISPLists, ISPView, ISPViews } from "../common/SPEntities";
+import { ISPContentType, ISPField, ISPLists, ISPViews } from "../common/SPEntities";
 import {orderBy } from '../controls/viewPicker/IViewPicker';
 
 export enum LibsOrderBy {

src/services/SPService.ts

@@ -2,7 +2,7 @@ import { BaseComponentContext } from '@microsoft/sp-component-base';
 import { ISPHttpClientOptions, SPHttpClient } from "@microsoft/sp-http";
 import filter from 'lodash/filter';
 import find from 'lodash/find';
-import { ISPContentType, ISPField, ISPList, ISPLists, IUploadImageResult, ISPView, ISPViews } from "../common/SPEntities";
+import { ISPContentType, ISPField, ISPList, ISPLists, IUploadImageResult, ISPViews } from "../common/SPEntities";
 import { SPHelper, urlCombine } from "../common/utilities";
 import { IContentTypesOptions, IFieldsOptions, ILibsOptions, ISPService, LibsOrderBy } from "./ISPService";
 import {orderBy } from '../controls/viewPicker/IViewPicker';

src/services/SPServiceMock.ts

@@ -1,5 +1,5 @@
 import { ISPService, ILibsOptions, IFieldsOptions, IContentTypesOptions } from "./ISPService";
-import { ISPContentType, ISPField, ISPLists, ISPView, ISPViews } from "../common/SPEntities";
+import { ISPContentType, ISPField, ISPLists, ISPViews } from "../common/SPEntities";
 import {orderBy } from '../controls/viewPicker/IViewPicker';
 
 export default class SPServiceMock implements ISPService {

src/webparts/controlsTest/components/ControlsTest.tsx

@@ -556,9 +556,9 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
       isTaxonomyTreeDivVisible: false,
       isTestControlDivVisible: false,
       isUploadFilesDivVisible: false,
+      isViewPickerDivVisible: false,
       toggleAll: false,
-      showAllFilters: false, 
-      isViewPickerDivVisible: false
+      showAllFilters: false,
     };
 
     this._onIconSizeChange = this._onIconSizeChange.bind(this);
@@ -2719,4 +2719,4 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
       isViewPickerDivVisible: checked
     });
   }
-}
+}