Skip to content

Commit bcdc5a6

Browse files
Changes requested by Alex dated 25Jun2023
1 parent 86867c3 commit bcdc5a6

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

src/controls/viewPicker/ViewPicker.tsx

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
1818

1919
private selectedKey: string | string[] = null;
2020
private async: Async;
21-
private _selectedView: string | string[] = null;
2221

2322
constructor(props: IViewPickerProps){
2423
super(props);
@@ -31,7 +30,6 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
3130
this.async = new Async(this);
3231
}
3332

34-
3533
public componentDidMount(): void {
3634
// Start retrieving the list views
3735
this.loadViews();
@@ -117,10 +115,10 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
117115
* Set the currently selected views(s);
118116
*/
119117
private setSelectedViews(): void {
120-
this._selectedView = cloneDeep(this.props.selectedView);
118+
let _selectedView = cloneDeep(this.props.selectedView);
121119

122120
this.setState({
123-
selectedView: this._selectedView,
121+
selectedView:_selectedView
124122
});
125123
}
126124

@@ -132,23 +130,27 @@ export class ViewPicker extends React.Component<IViewPickerProps, IViewPickerSta
132130
*/
133131
private onChange = (event: React.FormEvent<HTMLDivElement>, option: IDropdownOption, index?: number): void => {
134132
const { multiSelect, onSelectionChanged } = this.props;
135-
133+
let selectedViews : string | string[] = null;
136134
if (multiSelect) {
137-
let selectedViews = this._selectedView ? cloneDeep(this._selectedView) as string[] : [];
135+
selectedViews = this.state.selectedView ? cloneDeep(this.state.selectedView) as string[] : [];
138136

139137
if (option.selected) {
140138
selectedViews.push(option.key.toString());
141139
}
142140
else {
143141
selectedViews = selectedViews.filter(view => view !== option.key);
144142
}
145-
this._selectedView = selectedViews;
143+
this.setState({
144+
selectedView:selectedViews
145+
});
146146
}
147147
else {
148-
this._selectedView = option.key.toString();
148+
this.setState({
149+
selectedView:option.key.toString()
150+
});
149151
}
150152
if (onSelectionChanged) {
151-
onSelectionChanged(cloneDeep(this._selectedView));
153+
onSelectionChanged(cloneDeep(selectedViews));
152154
}
153155
}
154156

0 commit comments

Comments
 (0)